Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename String::ord_at to String::unicode_at #15519

Closed
Geequlim opened this issue Jan 9, 2018 · 4 comments
Closed

Rename String::ord_at to String::unicode_at #15519

Geequlim opened this issue Jan 9, 2018 · 4 comments
Labels
archived discussion enhancement topic:core
Milestone
3.1

Comments

@Geequlim
Copy link
Contributor

Geequlim commented Jan 9, 2018 •
edited
Loading

Godot version: Godot 3.0

The function name unicode_at should more meaningful than ord_at .
I think it is the good chance to make this rename before the 3.0 release.
@Geequlim Geequlim mentioned this issue Jan 9, 2018
Closed
@mhilbrunner
Copy link
Member

Is there agreement that this should be in 3.0?

@akien-mga
Copy link
Member

Nope, see the reference PR, this is for 3.1, if we agree on the change. I don't have a strong opinion either way, but I'm not sure unicode_at is much clearer regarding what the method does.

@mhilbrunner mhilbrunner added this to the 3.1 milestone Jan 12, 2018
@mhilbrunner
Copy link
Member

No opinion either. Isn't worse, but not sure its really better.

@akien-mga akien-mga mentioned this issue Feb 20, 2018
Closed
83 tasks
@akien-mga
Copy link
Member

Closing as it's now tracked in #16863.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
archived discussion enhancement topic:core
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
4 participants
@StraToN @mhilbrunner @akien-mga @Geequlim