Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node get_position_in_parent() and get_index() do the same #21802

Closed
KoBeWi opened this issue Sep 6, 2018 · 3 comments
Closed

Node get_position_in_parent() and get_index() do the same #21802

KoBeWi opened this issue Sep 6, 2018 · 3 comments

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Sep 6, 2018

I used get_index() a lot, but recently while randomly looking at documentation, I noticed the get_position_in_parent(). It has different description (!), but does the same. I looked at implementation and they literally are the same functions under different names and different descriptions, so it seems like unintended alias.

@eon-s
Copy link
Contributor

eon-s commented Sep 7, 2018

Related #16863

@akien-mga akien-mga changed the title get_position_in_parent() and get_index() do the same Node get_position_in_parent() and get_index() do the same Sep 10, 2018
@akien-mga
Copy link
Member

Both date back to the original open source commit, one should indeed be removed. Moving this to an entry in #16863.

@girng
Copy link

girng commented Apr 4, 2020

index implies it's a child of a node that has a parent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants