Godot 4 editor window disappears on BSPWM tilling manager when changing the workspace #68471

Evimilly · 2022-11-10T07:00:26Z

Godot version

v4.0.beta4.official [e675154]

System information

ArchLinux, BSPWM

Issue description

When i open the Godot 4.0 editor using BSPWM tiling window manager sometimes when switching between workspaces Godot editor window disappears.
It seems to happen more often when there's another window open on the same workspace as the editor.
Reproducible on beta 1, 2 and 4, didn't test on beta 3.
Reproducible on old alpha Godot 4.0 build (alpha 5).
Can't reproduce it on other TWM's like sway.
Never had this problem on 3.x, works as expected on 3.5.1
https://user-images.githubusercontent.com/28687947/201021555-70ac4d4e-36a4-46f8-8e4e-50d6cef18d62.mp4

Steps to reproduce

Open the editor
Rapidly switch a workspace from where Godot window is located to another and back
Window should disappear after awhile.

Minimal reproduction project

Not needed, can be reproduced on startup or/and on a new empty project.

The text was updated successfully, but these errors were encountered:

permelin · 2022-11-11T00:32:56Z

I have a similar issue #65425 with the XMonad tiling window manager, but in my case Godot crashes and terminates. There's clearly a race condition when the Godot window is hidden/shown. And it doesn't just happen to the editor but also games.

Evimilly · 2022-11-11T05:33:16Z

Tried other TWM's, here are the results:
sway (1:1.7) - can't reproduce
dwm (6.3-1) - can't reproduce
awesome (4.3) - can't reproduce
i3 (4.21.1) - can't reproduce
XMonad (0.17.1 & 0.17.0) - can't reproduce
Seems to be a BSPWM issue.

Calinou · 2022-11-16T16:08:20Z

Can you reproduce this when starting the editor with the --single-window command line argument? Note that starting the project manager with this argument won't carry it over to the editor, so you have to enable the Single Window Mode editor setting instead if you're going through the project manager.

Evimilly · 2022-11-17T07:47:12Z

v4.0.beta5.official [89a33d2]
./Godot_v4.0-beta5_linux.x86_64 --single-window or/and interface/editor/single_window_mode property enabled
Still reproducible.

ryze312 · 2022-12-11T19:56:23Z

For me it's seems to be happening only when sending Godot to a different workspace using
bspc node -d {1-9}

ryze312 · 2022-12-12T20:57:35Z

The problem seems to be with the order of events sent by BSPWM.

When changing workspaces, it sets WM_STATE_NORMAL and sends MapNotify before sending ConfigureNotify, causing wd.minimized to have an outdated value (true), while _window_minimize_check returns proper value (false) , since it checks for WM_STATE_ICONIC

godot/platform/linuxbsd/x11/display_server_x11.cpp

Lines 1993 to 1995 in 0a3f664

    
           } else if (wd.minimized && !_window_minimize_check(p_window)) { 
        
           	_set_wm_minimized(p_window, true); 
        
           }

This causes execution of _set_wm_minimized, which tells BSPWM to hide window, by setting it's internal hidden flag to 1

node_flag 0x00200006 0x0020000D 0x02E00003 hidden on

Logs with DISPLAY_SERVER_X11_DEBUG_LOGS_ENABLED and my additions to monitor this two values show, that indeed is the case

[471] MapNotify window=48234499 (0) 
MAP VALIDATE:
wd.minimized: true
minimize_check: false
[471] VisibilityNotify window=48234499 (0), state=0 
[471] Expose window=48234499 (0), count='0' 
[471] FocusIn window=48234499 (0), mode='3' 
[471] EnterNotify window=48234499 (0), mode='0' 
[471] ConfigureNotify window=48234499 (0), event=48234499, above=37748750, override_redirect=0 
WINDOW CHANGED:
wd.minimized: 1

This could be fixed by working around and calling _window_changed before mode validation here

godot/platform/linuxbsd/x11/display_server_x11.cpp

Lines 3771 to 3773 in 0a3f664

    
           // Have we failed to set fullscreen while the window was unmapped? 
        
           _validate_mode_on_map(window_id);

Or by calling show_desktop after stack in the focus_node in BSPWM source code

if (m->desk != d) {
    show_desktop(d);
    set_input_focus(n);
    has_input_focus = true;
    hide_desktop(m->desk);
    m->desk = d;
}

// ...

stack(d, n, true);
// <-- Somewhere here

ryze312 · 2022-12-13T02:01:12Z

Just adding _window_changed is not enough. Looking at _validate_mode_on_map it seems, that it only applies window properties to true. Why is that?

godot/platform/linuxbsd/x11/display_server_x11.cpp

Lines 1989 to 1995 in 0a3f664

    
           if (wd.fullscreen && !_window_fullscreen_check(p_window)) { 
        
           	_set_wm_fullscreen(p_window, true, wd.exclusive_fullscreen); 
        
           } else if (wd.maximized && !_window_maximize_check(p_window, "_NET_WM_STATE")) { 
        
           	_set_wm_maximized(p_window, true); 
        
           } else if (wd.minimized && !_window_minimize_check(p_window)) { 
        
           	_set_wm_minimized(p_window, true); 
        
           }

Shouldn't there be a check like this?

bool desiredFullscreen = _window_fullscreen_check(p_window);
bool desiredMaximized = _window_maximize_check(p_window, "_NET_WM_STATE");
bool desiredMinimized = _window_minimize_check(p_window);

if (wd.fullscreen != desiredFullscreen) {
	_set_wm_fullscreen(p_window, desiredFullscreen, wd.exclusive_fullscreen);
} else if (wd.maximized != desiredMaximized) {
	_set_wm_maximized(p_window, desiredMaximized);
} else if (wd.minimized != desiredMinimized) {
	_set_wm_minimized(p_window, desiredMinimized);
}

ana-rchy · 2023-03-16T18:07:14Z

is there any workaround to this for now? its very tedious having to manually find and kill off the right godot process and reopen my project just to start working on it again every 5-10 mins

wnelson01 · 2023-03-16T23:13:10Z

is there any workaround to this for now? its very tedious having to manually find and kill off the right godot process and reopen my project just to start working on it again every 5-10 mins

#69995 seemed to have fixed it for me

The default behaviour for X11 is to crash even on non-fatal errors when there is no error handler set. This change allows the window to stay open and may enable users to save their work when things go wrong. This acts as a workaround for godotengine#65425 and godotengine#68471

ana-rchy · 2023-06-18T22:01:32Z

is this still gonna be worked on? the issue persists in the current godot version

wearepixelated · 2023-06-19T13:55:33Z

Confirmed - v4.0.3 on bspwm, switching the active workspace, still blackholes the Editor

ana-rchy · 2023-06-19T15:24:20Z

Confirmed - v4.0.3 on bspwm, switching the active workspace, still blackholes the Editor

same with latest master branch compile (v4.1 beta), which includes a commit that conflicts with ryze312's branch

ana-rchy · 2023-06-20T15:01:09Z

latest master branch + accepting ryze312's commits for merging fixes the issue

ana-rchy · 2023-07-06T13:06:10Z

latest master branch + accepting ryze312's commits for merging fixes the issue

nvm

AntonioDell · 2023-07-14T21:26:02Z

The issue also happens on Pop Shell (an i3-like tiling window management in Pop OS) and can be reproduced reliably like this:

Enable windows tiling (SUPER+Y or from the default app bar)
From any project, click "Run Project" (F5)
Move the running project window to a different workspace (SUPER+Shift+Down)
Close the running project window and return to the workspace with the editor (SUPER+Cmd+Up)
The editor window is minimized and cannot be made to stay open anymore when focusing it

I found one workaround which let's me quickly solve the issue again:

Follow instructions above to reproduce the issue
Open another Godot instance, such that a new Godot Project window opens on the same workspace, where the buggy editor is
Focus the buggy editor window (SUPER key to open the launcher and navigate with arrow buttons to the editor then click Enter)
Close the new Godot Project window again
The editor window will stay open

Hopefully this helps in tackling this annoying issue.

ana-rchy · 2023-07-14T22:57:57Z

The issue also happens on Pop Shell (an i3-like tiling window management in Pop OS) and can be reproduced reliably like this:

1. Enable windows tiling (SUPER+Y or from the default app bar)

2. From any project, click "Run Project" (F5)

3. Move the running project window to a different workspace (SUPER+Shift+Down)

4. Close the running project window and return to the workspace with the editor (SUPER+Cmd+Up)

5. The editor window is minimized and cannot be made to stay open anymore when focusing it

I found one workaround which let's me quickly solve the issue again:

1. Follow instructions above to reproduce the issue

2. Open another Godot instance, such that a new Godot Project window opens on the same workspace, where the buggy editor is

3. Focus the buggy editor window  (SUPER key to open the launcher and navigate with arrow buttons to the editor then click Enter)

4. Close the new Godot Project window again

5. The editor window will stay open

Hopefully this helps in tackling this annoying issue.

can confirm this works on latest AUR release of godot-mono-bin on bspwm, this some black magic shit

Evimilly · 2023-08-01T14:02:31Z

Accidentally closed the issue, sorry.

Lense · 2023-08-08T01:40:20Z

With Godot 4.1.1 and bspwm, a temp fix is unsetting the node's hidden value: bspc node any.hidden -g hidden=off (sometimes I have to run that twice)

andro404-MC · 2023-09-15T16:06:06Z

With Godot 4.1.1 and bspwm, a temp fix is unsetting the node's hidden value: bspc node any.hidden -g hidden=off (sometimes I have to run that twice)

Thank you for the workaround, it's enough for me, but this issue should be fixed.

Evimilly · 2023-10-18T15:33:38Z

I can't seem to reproduce the issue anymore, can anyone else check if they're still experiencing it? Maybe other TWM's are still plagued by the issue?
On Godot 4.1.2 stable the issue is reproducible.
BSPWM 0.9.10-3 from Arch repos
Godot latest git compiled (7f884b4)
scons p=linuxbsd target=editor tools=yes optimize=speed use_lto=yes use_llvm=yes linker=mold -j12

permelin · 2023-10-18T17:44:29Z

Just tried it on a fresh git pull. I'm using the XMonad window manager and Godot used to randomly crash when switching workspaces. Not anymore. The error that caused the crash now seems to be caught and logged instead.

Switching between workspaces will now sometimes show this in the editor's console:

  platform/linuxbsd/x11/display_server_x11.cpp:887 - Unhandled XServer error: BadMatch (invalid parameter attributes)
     Major opcode of failed request: 42
     Serial number of failed request: 0
     Current serial number in output stream: 29854

That error is what I used to see in gdb/lldb when it crashed before.

permelin · 2023-10-18T17:58:29Z

#75099 seems to be what fixed it for me. But that was merged already in 4.1 so if you still had the problem in 4.1.2 then that can't be relevant for you.

ana-rchy · 2023-10-19T15:01:42Z

#75099 seems to be what fixed it for me. But that was merged already in 4.1 so if you still had the problem in 4.1.2 then that can't be relevant for you.

i can now move godot windows to a different workspace, but if i am loading up godot or a project, and switch workspaces while thats happening, the window becomes hidden

Evimilly · 2023-11-30T13:52:33Z

#75099 seems to be what fixed it for me. But that was merged already in 4.1 so if you still had the problem in 4.1.2 then that can't be relevant for you.

i can now move godot windows to a different workspace, but if i am loading up godot or a project, and switch workspaces while thats happening, the window becomes hidden

Can you please try it on stable 4.2? It is fixed for me, so if you don't have any issues either I'm closing this issue.

AntonioDell · 2023-12-01T13:57:58Z

I cannot trigger the behavior anymore in 4.2 by following my previously posted procedure. So it seems to be fixed.
Very happy about that :D

Evimilly · 2023-12-07T20:02:37Z

Well, it's fixed for me on Godot 4.2.
As there have been no reports saying otherwise from anyone else, I'm closing this issue.

Calinou added bug platform:linuxbsd topic:porting labels Nov 16, 2022

Calinou mentioned this issue Nov 16, 2022

Godot4 crashes on awesome wm #68715

Open

boruok mentioned this issue Dec 1, 2022

Reloading project cause window to appear in different workspace #69435

Closed

ryze312 mentioned this issue Dec 13, 2022

Update window properties on PropertyNotify, clipboard manipulation refactor, general cleanup #69995

Closed

Calinou mentioned this issue Dec 13, 2022

Editor "disappears" #70019

Closed

Calinou added the confirmed label Dec 13, 2022

Calinou added this to the 4.0 milestone Dec 13, 2022

Calinou added this to 4.x Priority Issues Dec 13, 2022

Calinou moved this to To Assess in 4.x Priority Issues Dec 13, 2022

clayjohn removed this from 4.x Priority Issues Jan 26, 2023

akien-mga modified the milestones: 4.0, 4.1 Feb 17, 2023

rsubtil mentioned this issue Mar 3, 2023

godot window completely dissapears, but process still runs when moving godot window to another workspace on a window manager #74317

Closed

mxnemu mentioned this issue Mar 19, 2023

[Linux/X11] Add a default error handler for X11 to avoid crashes. #75099

Merged

YuriSizov modified the milestones: 4.1, 4.2 Jun 26, 2023

Evimilly closed this as completed Aug 1, 2023

Evimilly reopened this Aug 1, 2023

Calinou mentioned this issue Aug 29, 2023

godot window freezes up completely if switching workspaces while busy #81099

Closed

YuriSizov modified the milestones: 4.2, 4.3 Nov 15, 2023

Evimilly closed this as completed Dec 7, 2023

AThousandShips modified the milestones: 4.3, 4.2 Dec 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Godot 4 editor window disappears on BSPWM tilling manager when changing the workspace #68471

Godot 4 editor window disappears on BSPWM tilling manager when changing the workspace #68471

Evimilly commented Nov 10, 2022

permelin commented Nov 11, 2022

Evimilly commented Nov 11, 2022

Calinou commented Nov 16, 2022

Evimilly commented Nov 17, 2022

ryze312 commented Dec 11, 2022

ryze312 commented Dec 12, 2022

ryze312 commented Dec 13, 2022 •

edited

Loading

ana-rchy commented Mar 16, 2023

wnelson01 commented Mar 16, 2023

ana-rchy commented Jun 18, 2023 •

edited

Loading

wearepixelated commented Jun 19, 2023

ana-rchy commented Jun 19, 2023

ana-rchy commented Jun 20, 2023

ana-rchy commented Jul 6, 2023

AntonioDell commented Jul 14, 2023 •

edited

Loading

ana-rchy commented Jul 14, 2023

Evimilly commented Aug 1, 2023

Lense commented Aug 8, 2023

andro404-MC commented Sep 15, 2023

Evimilly commented Oct 18, 2023 •

edited

Loading

permelin commented Oct 18, 2023

permelin commented Oct 18, 2023

ana-rchy commented Oct 19, 2023 •

edited

Loading

Evimilly commented Nov 30, 2023

AntonioDell commented Dec 1, 2023 •

edited

Loading

Evimilly commented Dec 7, 2023

Godot 4 editor window disappears on BSPWM tilling manager when changing the workspace #68471

Godot 4 editor window disappears on BSPWM tilling manager when changing the workspace #68471

Comments

Evimilly commented Nov 10, 2022

Godot version

System information

Issue description

Steps to reproduce

Minimal reproduction project

permelin commented Nov 11, 2022

Evimilly commented Nov 11, 2022

Calinou commented Nov 16, 2022

Evimilly commented Nov 17, 2022

ryze312 commented Dec 11, 2022

ryze312 commented Dec 12, 2022

ryze312 commented Dec 13, 2022 • edited Loading

ana-rchy commented Mar 16, 2023

wnelson01 commented Mar 16, 2023

ana-rchy commented Jun 18, 2023 • edited Loading

wearepixelated commented Jun 19, 2023

ana-rchy commented Jun 19, 2023

ana-rchy commented Jun 20, 2023

ana-rchy commented Jul 6, 2023

AntonioDell commented Jul 14, 2023 • edited Loading

ana-rchy commented Jul 14, 2023

Evimilly commented Aug 1, 2023

Lense commented Aug 8, 2023

andro404-MC commented Sep 15, 2023

Evimilly commented Oct 18, 2023 • edited Loading

permelin commented Oct 18, 2023

permelin commented Oct 18, 2023

ana-rchy commented Oct 19, 2023 • edited Loading

Evimilly commented Nov 30, 2023

AntonioDell commented Dec 1, 2023 • edited Loading

Evimilly commented Dec 7, 2023

ryze312 commented Dec 13, 2022 •

edited

Loading

ana-rchy commented Jun 18, 2023 •

edited

Loading

AntonioDell commented Jul 14, 2023 •

edited

Loading

Evimilly commented Oct 18, 2023 •

edited

Loading

ana-rchy commented Oct 19, 2023 •

edited

Loading

AntonioDell commented Dec 1, 2023 •

edited

Loading