Skip to content

Conversation

@TCROC
Copy link
Contributor

@TCROC TCROC commented May 14, 2025

Just another PR to consider alongside #106413.

Fixes: #106376

Hopefully this doesn't bring back the warnings that the other PR does and we get to have our cake and eat it to! :)

@TCROC TCROC requested a review from a team as a code owner May 14, 2025 21:57
@TCROC
Copy link
Contributor Author

TCROC commented May 14, 2025

@akien-mga CC

🤞 this one doesn't bring it all those warnings. And pray the cosmic rays don't ruin our day.

@TCROC
Copy link
Contributor Author

TCROC commented May 14, 2025

That's interesting... why don't I encounter these errors when building on my local?

@akien-mga
Copy link
Member

That's the same thing I did in #106413, minus some cosmetic cleanup. It does bring back the warnings sadly.

@akien-mga
Copy link
Member

That's interesting... why don't I encounter these errors when building on my local?

You probably don't build with warnings=extra werror=yes like the CI does.

@TCROC
Copy link
Contributor Author

TCROC commented May 14, 2025

Ah I see. I'll still test your PR tho to confirm that it works (or doesn't) :)

@akien-mga
Copy link
Member

To clarify, my PR has two commits:

  • The first is the same as yours, and introduced warnings
  • The second tries another approach by keeping CPPEXTPATH but changing the order

@TCROC
Copy link
Contributor Author

TCROC commented May 14, 2025

Ah I see... I'm testing the 2nd commit now then :). Was confused at first but that makes much more sense :)

@Calinou Calinou added this to the 4.5 milestone May 15, 2025
@TCROC
Copy link
Contributor Author

TCROC commented May 20, 2025

Hey @akien-mga. Which PR between ours are you wanting to go with? I don't mind which. I'm just not sure what to do to make the pipeline happy.

@Repiteo
Copy link
Contributor

Repiteo commented Sep 18, 2025

Superseded by #109749

@Repiteo Repiteo closed this Sep 18, 2025
@Repiteo Repiteo removed this from the 4.5 milestone Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants