-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pvrtc encoder #28563
Fix pvrtc encoder #28563
Conversation
Always resize image to square of power2 Enable mipmaps only if original texture has it enabled Fix godotengine#28534, godotengine#28541
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem good, just need a quick check from @reduz to confirm if there was any reason to modulate by 8 instead of po2.
Comments from @reduz on IRC:
|
@akien-mga may be somebody should fix thirdparty pvrtc encoder?
|
@akien-mga I'm looking around the Internet and can not find open pvrtc encoder which doesn't require square pow2 texture input. |
Could not get another answer from @reduz, so let's stick to what the thirdparty library requires. Thanks for looking into this :) |
Thanks! |
Cherry-picked for 3.1.2. |
Always resize image to square of power2
Enable mipmaps only if original texture has it enabled
Fix #28534, fix #28541