Clean up profiler #37966
Merged
Clean up profiler #37966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pkowal1982
commented
Apr 17, 2020
pkowal1982
commented
- Fix issue where you can't select by mouse all frames (for example frame 0 can be selected only by edit field)
- Disable frame edit field when no data available
- Disable clear button when nothing to clean
- Align cursor to the middle of selected frame (it was misplaced)
- Remove some dead code
|
@pkowal1982 Could you look into rebasing this pull request on the latest |
|
@Calinou yeah, I'll try to look into it before this weekend. |
pkowal1982
force-pushed
the
cleanup-profiler
branch
from
109bbb2 to
37af6a5
Compare
pkowal1982
force-pushed
the
cleanup-profiler
branch
2 times, most recently
from
8f521b3 to
d1cd56f
Compare
|
@Calinou Done. |
Faless
requested changes
Apr 6, 2021
| void EditorProfiler::add_frame_metric(const Metric &p_metric, bool p_final) { | ||
| ++last_metric; | ||
| if (last_metric >= frame_metrics.size()) { | ||
| last_metric = 0; | ||
| } | ||
|
|
||
| total_metrics++; | ||
| if (total_metrics > frame_metrics.size()) | ||
| total_metrics = frame_metrics.size(); |
There was a problem hiding this comment.
if (total_metrics > frame_metrics.size()) {
total_metrics = frame_metrics.size();
}| cursor_metric_edit->set_min(_get_frame_metric(0).frame_number); | ||
|
|
||
| if (!seeking) | ||
| cursor_metric_edit->set_value(p_metric.frame_number); |
There was a problem hiding this comment.
if (!seeking) {
cursor_metric_edit->set_value(p_metric.frame_number);
}
pkowal1982
force-pushed
the
cleanup-profiler
branch
from
d1cd56f to
cd39067
Compare
pkowal1982
force-pushed
the
cleanup-profiler
branch
from
cd39067 to
f93de6f
Compare
Faless
approved these changes
Apr 10, 2021
There was a problem hiding this comment.
I've tested it a bit, it's a great improvement.
There are still issues when you select a frame and then close the game without resuming it (the play/stop button stays disabled), but that's already happening in master so we can address that in a separate PR.
Great job 🏆 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.