-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Label to TextLabel #40124
Rename Label to TextLabel #40124
Conversation
70e16ab
to
b353554
Compare
What exactly the reason for change the name of this node? |
For better search results. Allows for typing text or label when filtering nodes. |
In addition to better search results:
The improved search results also helps people who haven't used Godot before and are just searching for "Text". |
I don't like it - Label is a simple explanatory term in many GUI API's, the gain of adding "Text" is very little in my opinion |
I'd much prefer a general purpose Also, how often do we actually need to use something like
The poor searching might be already addressed by #39990. Perhaps the searching could also be improved to seek within method descriptions to suggest better results. |
What about See also #20611. |
b353554
to
4226c8e
Compare
eae1930
to
b75b7af
Compare
b75b7af
to
4d49f9b
Compare
4d49f9b
to
5620450
Compare
8940e50
to
534437f
Compare
534437f
to
503f60e
Compare
We discussed this in a PR review meeting today, and decided to reject the proposal (and the PR).
That's a more valid point in my opinion (also was @Faless' opinion). Godot uses |
Implements #16863 (comment), implements and closes godotengine/godot-proposals#1815.
This is a huge change and probably conflicts with tons of other PRs.