Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS] Fix crash on failed fork. #41188

Merged
merged 1 commit into from
Aug 11, 2020

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 11, 2020

Use SIGKILL instead of SIGABRT. This should not have any negative effects, but probably we should make NSTask based implementation at some point (see #17629).

Fixes #17615

@bruvzg bruvzg added this to the 4.0 milestone Aug 11, 2020
@bruvzg bruvzg requested a review from hpvb as a code owner August 11, 2020 14:49
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 11, 2020
@akien-mga akien-mga requested a review from neikeq August 11, 2020 14:51
@akien-mga akien-mga merged commit 5ee0af0 into godotengine:master Aug 11, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.3.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 12, 2020
@bruvzg bruvzg deleted the fix_mac_fork_crash branch August 26, 2020 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS OS.execute raises SIGABRT on invalid binary name, registers as crash
2 participants