Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed String.ord_at to unicode_at #43790

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Renamed String.ord_at to unicode_at #43790

merged 1 commit into from
Jan 27, 2021

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Nov 23, 2020

One of the proposed renames from #16863

@Chaosus Chaosus requested a review from a team as a code owner November 23, 2020 11:49
@Chaosus Chaosus added this to the 4.0 milestone Nov 23, 2020
@Chaosus Chaosus requested a review from vnen November 23, 2020 12:20
@vnen
Copy link
Member

vnen commented Jan 11, 2021

The changes in GDNative aren't needed since I'm removing the methods there.

@Chaosus
Copy link
Member Author

Chaosus commented Jan 26, 2021

Rebased / Removed GDNative methods

vnen
vnen approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@vnen vnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. Maybe @bruvzg wants to confirm this is a good name.

bruvzg
bruvzg approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unicode_at seems better than ord_at.

@akien-mga akien-mga merged commit 964c145 into godotengine:master Jan 27, 2021
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the rename_ord_at branch January 27, 2021 18:44
@Chaosus Chaosus mentioned this pull request Jan 27, 2021
Closed
83 tasks
@raulsntos raulsntos mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

@vnen vnen vnen approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Chaosus @vnen @akien-mga @bruvzg