Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Camera2D offset_h and offset_v properties #44232

Merged
merged 1 commit into from
Dec 28, 2020

Conversation

madmiraal
Copy link
Contributor

@madmiraal madmiraal commented Dec 9, 2020

As identified here and here, currently, Camera2D has an offset property, an offset_h property and an offset_v property. The offset property sets the viewport of the camera relative to its position. The offset_h and offset_v properties control the relative position of the viewport within the drag margins (when enabled).

This PR groups all the drag properties together in the editor and renames the following and their underlying methods and variables:

  • offset_h -> drag_horizontal_offset
  • offset_v to drag_vertical_offset
  • drag_margin_h_enabled -> drag_horizontal_enabled
  • drag_margin_v_enabled -> drag_vertical_enabled
  • drag_margin_left -> drag_left_margin
  • drag_margin_top -> drag_top_margin
  • drag_margin_right -> drag_right_margin
  • drag_margin_bottom -> drag_top_bottom

Part of #16863.

@madmiraal
Copy link
Contributor Author

Rebased following merge of #44605.

@madmiraal madmiraal force-pushed the rename-camera2d-drag-offset branch from 1e9b40f to 04ab6c3 Compare December 28, 2020 11:01
@akien-mga akien-mga merged commit 18bbd64 into godotengine:master Dec 28, 2020
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the rename-camera2d-drag-offset branch December 29, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants