Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rect intersection documentation, and rename method on Mono #44582

Merged
merged 1 commit into from
Dec 27, 2020
Merged

Update Rect intersection documentation, and rename method on Mono #44582

merged 1 commit into from
Dec 27, 2020

Conversation

nathanfranke
Copy link
Contributor

No description provided.

@nathanfranke nathanfranke requested a review from a team as a code owner December 22, 2020 04:09
@nathanfranke nathanfranke force-pushed the document-rect-intersection branch from d337b10 to 66c079e Compare December 22, 2020 04:25
@nathanfranke nathanfranke changed the title Document what Rect intersection returns if Rects do not intersect Update Rect intersection documentation, and rename method on Mono Dec 22, 2020
@nathanfranke nathanfranke force-pushed the document-rect-intersection branch from 66c079e to 8885a99 Compare December 22, 2020 04:26
@aaronfranke aaronfranke mentioned this pull request Dec 22, 2020
Merged
@nathanfranke nathanfranke force-pushed the document-rect-intersection branch from 8885a99 to 96041e2 Compare December 22, 2020 04:34
aaronfranke
aaronfranke approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The C# changes are good, and the doc changes also look good.

@nathanfranke nathanfranke force-pushed the document-rect-intersection branch 5 times, most recently from 5e5337c to 99d63c8 Compare December 23, 2020 16:41
@Calinou Calinou added this to the 4.0 milestone Dec 23, 2020
@aaronfranke aaronfranke mentioned this pull request Dec 27, 2020
Closed
83 tasks
@nathanfranke nathanfranke force-pushed the document-rect-intersection branch from 99d63c8 to 3fda53c Compare December 27, 2020 04:17
@akien-mga akien-mga merged commit bf9db22 into godotengine:master Dec 27, 2020
@akien-mga
Copy link
Member

Thanks!

@nathanfranke nathanfranke deleted the document-rect-intersection branch December 9, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madmiraal madmiraal madmiraal left review comments

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
documentation enhancement topic:dotnet
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@nathanfranke @akien-mga @aaronfranke @madmiraal @Calinou