Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning spam when using --help or --version command line argument #44800

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Dec 29, 2020

Follow-up to #44393.

When a project setting is not found, a warning message is printed. This moves the default value declaration so it can be found when the --help or --version command line arguments are used.

…ment

When a project setting is not found, a warning message is printed.
This moves the default value declaration so it can be found when
the `--help` or `--version` command line arguments are used.
@Calinou Calinou force-pushed the fix-stdout-flush-project-setting branch from 02968c4 to 5cd37de Compare December 29, 2020 21:52
@Calinou Calinou added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:core labels Dec 29, 2020
@Calinou Calinou added this to the 4.0 milestone Dec 29, 2020
@akien-mga akien-mga merged commit f69c116 into godotengine:master Dec 30, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Dec 30, 2020
@Calinou Calinou deleted the fix-stdout-flush-project-setting branch March 31, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants