Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise SIGKILL instead of CRASH_NOW in child process when fork fails #45157

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Raise SIGKILL instead of CRASH_NOW in child process when fork fails #45157

merged 1 commit into from
Jan 13, 2021

Conversation

madmiraal
Copy link
Contributor

As identified by @bruvzg here, CRASH_NOW is generating unnecessary stack traces when a fork fails to create a child process.

This PR reverts to using raise(SIGKILL);

@madmiraal madmiraal added this to the 4.0 milestone Jan 13, 2021
@madmiraal madmiraal requested a review from hpvb as a code owner January 13, 2021 10:14
@madmiraal madmiraal requested a review from bruvzg January 13, 2021 10:14
bruvzg
bruvzg approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess OS::create_process should have the same change.

@akien-mga akien-mga merged commit 59495ad into godotengine:master Jan 13, 2021
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the fix-44514 branch January 13, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

@hpvb hpvb Awaiting requested review from hpvb

Assignees
No one assigned
Labels
bug regression topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@madmiraal @akien-mga @bruvzg