Rotation APIs: Better exposure for degrees methods #4571
Conversation
Made public the various set/getters for rotations in degrees. For consistency, renamed the exposed method names to remove the leading underscore, and kept the old names with a deprecation warning. Fixes godotengine#4511.
|
I think I found all places where such degrees methods were defined, but if you know of other classes with this mechanism, please tell me. Until we implement a proper method for deprecating stuff in #4397, I've kept the old names and added a deprecating warning manually. Note that the current method names are quite versatile, as we have |
| // Could be removed after a couple releases. | ||
| Vector3 Spatial::_get_rotation_deg() const { | ||
|
|
||
| WARN_PRINT("Deprecated method Spatial._get_rotation_deg(): This method was renamed to get_rotation_deg. Please adapt your code accordingly, as the old method will be obsoleted."); |
There was a problem hiding this comment.
I guess nobody uses this method, and even if he does, he shouldn't expect it to work, since it is private API.
There was a problem hiding this comment.
Well GDScript users don't know if it's private or public in C++, the function was exposed to GDScript, so we need to warn users about it becoming deprecated.
|
There are too many namings for the same function, set_rot, set_rotation, set_rotation_deg, set_rotationd, set_rotd, also there are thing like set_param functions that takes an angle, should we add things like PARAM_ANGLE_DEG, i think is too much bloat, there shoul be only one rotation type function either in degrees or radians and use deg2rad or rad2deg, also it is confusing that angles in the editor are expressed in degrees whereas angles in scripts are expresed in radians, probabily theres a good reason for that, but for beginners i dont think that is friendly. |
Made public the various set/getters for rotations in degrees.
For consistency, renamed the exposed method names to remove the leading
underscore, and kept the old names with a deprecation warning.
Fixes #4511.