Remove Navigation2D/3D nodes #46786
Merged
Remove Navigation2D/3D nodes #46786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groud
force-pushed
the
navigation
branch
2 times, most recently
from
79c9ac0 to
249f680
Compare
AndreaCatania
approved these changes
Mar 10, 2021
akien-mga
reviewed
Mar 10, 2021
|
Done! |
|
Thanks! |
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements this : godotengine/godot-proposals#691 (comment)
Finally we can get rid of those nodes. This avoid the need for NavigationRegion to have them as a direct parent, or, for any NavigationAgent or NavigationObstacle, to have them in their ancestors.
To replace them, the navigation map RID they used to hold has been moved to the world2D/3D resource.
This PR is a draft, as for now there is no way to have multiple maps per world, as we used to. I'll add a similar feature in a second commit by adding a system of layers/masks to the different regions/agents. It will work as it does for physics layers.
Edit: It seems that things works correctly in the 2D demo with little changes to the project. The 3D demo does not work in 4.0 (no meshes appears), so I cannot test.