Fix crash caused by null parameter passed to CameraServer.add_feed() #47571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #46181 CameraServer.add_feed() takes a CameraFeed object type as parameter. Passing in another type of data while binding the method it will make tha parameter null. Added a check for null which returns from function and does not make the engine crash anymore.
Calinou
added
bug
crash
topic:core
topic:xr
cherrypick:3.3
and removed
topic:core
labels
m4gr3d
approved these changes
Apr 2, 2021
|
Thanks! |
|
Cherry-picked for 3.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46181
CameraServer.add_feed() takes a CameraFeed object type as parameter.
Passing in another type of data while binding the method it will make
that parameter null.
Added a check for null which returns from function and does not make the
engine crash anymore.
Important note: the issue was for 3.x but I noticed in master this is also the case
and I know that it's best to pull request to master and then cherry pick to 3.x
(I will also do that one if this is merged). I was not able to test on master because
I can't run the engine compiled for master for some reason but the change is small
enough to not affect it in a bad way even if the issue is not reproducible in 4.0
(if someone could confirm the issue is still present there, that would be great).