Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix few bugs in the context menu for Comment node in visual shaders #47624

Merged
merged 1 commit into from
Apr 4, 2021
Merged

Fix few bugs in the context menu for Comment node in visual shaders #47624

merged 1 commit into from
Apr 4, 2021

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Apr 4, 2021

Fixes few bugs after #46273 which are:

  1. A bug which makes HSeparators duplication on menu calling
  2. A bug that does not clear the previous options upon clicking on another (non-Comment) node

@Chaosus Chaosus requested a review from a team as a code owner April 4, 2021 15:07
@Chaosus Chaosus changed the title Fix few bugs in the context menu for Comment node Fix few bugs in the context menu for Comment node in visual shaders Apr 4, 2021
@Chaosus Chaosus added this to the 4.0 milestone Apr 4, 2021
@akien-mga akien-mga merged commit a864a70 into godotengine:master Apr 4, 2021
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the vs_fix_context_menu_separator branch April 4, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:shaders
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Chaosus @akien-mga