Expose Vulkan internal values for access from extensions #52203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
BastiaanOlij
force-pushed
the
expose_vulkan_info_to_extensions
branch
6 times, most recently
from
fd33b17 to
c504e31
Compare
reduz
approved these changes
Sep 9, 2021
BastiaanOlij
force-pushed
the
expose_vulkan_info_to_extensions
branch
from
c504e31 to
506ae80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes a few internal values in Vulkan that are needed in various extensions and can't be accessed.
@reduz I'm not happy about the solution so I'm up for suggestions on how to improve this. It's Vulkan only data that is supposed to stay internal and not exposed to GDScript nor exposed on the RenderingDevice base class. But we have no mechanism in place right now to only expose this data when Vulkan is used and then only to extensions.
@vnen I noticed that RenderingDevice::get_singleton() isn't available in extensions, is this just a matter of binding that method or is there another mechanism by which to do this?