Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): Clipboard get/set missing implement #52244

Closed
wants to merge 3 commits into from
Closed

Conversation

kyoz
Copy link

@kyoz kyoz commented Aug 30, 2021

This should fix the get/set clipboard not working on iphone mentioned in #52228

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's extra space before the ; in the function declaration. Everything else is OK, it's the same code used in 4.x.

diff --git a/platform/iphone/os_iphone.h b/platform/iphone/os_iphone.h
index f0112a7..ad9a8ee 100644
--- a/platform/iphone/os_iphone.h
+++ b/platform/iphone/os_iphone.h
@@ -109,7 +109,7 @@ public:
 	virtual String get_name() const;
 	virtual String get_model_name() const;
 
-	virtual void set_clipboard(const String &p_text) ;
+	virtual void set_clipboard(const String &p_text);
 	virtual String get_clipboard() const;
 
 	Error shell_open(String p_uri);

@kyoz
Copy link
Author

kyoz commented Aug 31, 2021

There's extra space before the ; in the function declaration. Everything else is OK, it's the same code used in 4.x.

diff --git a/platform/iphone/os_iphone.h b/platform/iphone/os_iphone.h
index f0112a7..ad9a8ee 100644
--- a/platform/iphone/os_iphone.h
+++ b/platform/iphone/os_iphone.h
@@ -109,7 +109,7 @@ public:
 	virtual String get_name() const;
 	virtual String get_model_name() const;
 
-	virtual void set_clipboard(const String &p_text) ;
+	virtual void set_clipboard(const String &p_text);
 	virtual String get_clipboard() const;
 
 	Error shell_open(String p_uri);

Thank @bruvzg , i have updated

@mhilbrunner
Copy link
Member

Looks good. Can you squash the commits into one, please? :) Then it can be merged.

@kyoz kyoz deleted the branch godotengine:3.x September 10, 2021 14:47
@kyoz kyoz closed this Sep 10, 2021
@kyoz kyoz deleted the 3.x branch September 10, 2021 14:47
@kyoz
Copy link
Author

kyoz commented Sep 10, 2021

Hi @mhilbrunner , i'v squashed but maybe i'm doing something wrong :D, should i open a pr again or reopen it will auto get change from my branch @@

@mhilbrunner
Copy link
Member

Somewhere along the line, you've ended up deleting the branches. :)
You'll need to either fix those or submit a new PR, referring to this one in the description. Feel free to ping me if you do.
We can't reopen a PR with a deleted branch.

If you need help with this, feel free to reach out to us on chat.godotengine.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants