Draggin in/out from ports to create nodes in Animation Blend Tree editor #52827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosus
force-pushed
the
blend_tree_connection_improvement
branch
3 times, most recently
from
36a8f6c to
0865954
Compare
|
The dragging feature looks great. Haven't done the technical review or the compile test yet though. |
AaronRecord
suggested changes
Sep 19, 2021
Chaosus
force-pushed
the
blend_tree_connection_improvement
branch
4 times, most recently
from
d33fd5c to
4dda360
Compare
Chaosus
force-pushed
the
blend_tree_connection_improvement
branch
from
4dda360 to
8e6fdd5
Compare
akien-mga
approved these changes
Sep 20, 2021
|
Thanks! |
| @@ -905,13 +948,13 @@ AnimationNodeBlendTreeEditor::AnimationNodeBlendTreeEditor() { | |||
| add_node->connect("about_to_popup", callable_mp(this, &AnimationNodeBlendTreeEditor::_update_options_menu)); | |||
|
|
|||
| add_options.push_back(AddOption("Animation", "AnimationNodeAnimation")); | |||
| add_options.push_back(AddOption("OneShot", "AnimationNodeOneShot")); | |||
There was a problem hiding this comment.
Running clang tidy on the entire engine- this line was changed.
2 is implicitly converted to true since the third constructor parameter of AddOption is a bool. Is this supposed to be true, or is AddOption supposed to take an int? Assuming the latter since the parameter has count in the name.
Edit: Actually it's pretty clear the parameter should be int. I changed it myself. You can track my changes at #55785.
P.S: Might be an hour or so until I push
There was a problem hiding this comment.
Yeah, it was a small mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QoL enhancement for that editor to allow users to create auto-connected nodes by dragging from the ports (like VisualShader already):