Fix errors with invalid bone node path in Polygon2D #54527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouleyKetchoupp
added
bug
topic:core
topic:editor
regression
cherrypick:3.x
NodePath properties are designed to be relative to the given node, so validity checks are failing in the editor for Polygon2D nodes, which are relative to the Skeleton2D node rather than the Polygon2D node. Fixed by saving bone paths as String properties instead of NodePath. Shouldn't cause a difference for performance since NodePath properties are technically saved as String anyway.
pouleyKetchoupp
force-pushed
the
fix-polygon-bone-path-errors
branch
from
231c229 to
8d9619a
Compare
akien-mga
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
As we discussed on Rocket.Chat, this may not be the "correct" fix for this issue, but for the purpose of the imminent 3.4 release, it's the safest option.
A refactor/compat breaking change could be done to do this better for 4.0 (thus undoing these changes on the way).
|
Thanks! Cherry-picked for 3.4. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodePath properties are designed to be relative to the given node, so validity checks are failing in the editor for Polygon2D nodes, which are relative to the Skeleton2D node rather than the Polygon2D node.
Fixed by saving bone paths as String properties instead of NodePath.
Shouldn't cause a difference for performance since NodePath properties are technically saved as String anyway.
Fixes #52126 (regression from #49812).