Fix XR viewport size overrule and incorrect usage of internal size #56416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In XR we override the size of the viewport to what the XR interface requires (often a multiple of the screen resolution of the HMD device), this broke with the changes for FSR. The render target is created at the viewport resolution, not the scaled down resolution for FSR (which is calculated during _configure_3d_render_buffers, and used to create the 3D render buffers).
I've also moved the check for resizing higher in the draw_viewports loop, same fix as I applied in Godot 3, to fix issues around changing settings.