Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve looks and consistency of tabs #56738

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

YeldhamDev
Copy link
Member

This PR does the following:

  • Make TabBar draw the select tab on top, like TabContainer.
  • Make TabBar draw its unselected tabs in the same way as TabContainer.
  • Modify the "tab_current" texture used by both TabBar and TabContainer to better blend in with the panel.
Before: After:
Screenshot_20220112_195856 Screenshot_20220112_195530

@YeldhamDev YeldhamDev added this to the 4.0 milestone Jan 13, 2022
@YeldhamDev YeldhamDev requested a review from a team as a code owner January 13, 2022 00:36
@YuriSizov
Copy link
Contributor

YuriSizov commented Jan 13, 2022

Note that the theme changes would have to be redone when the new default theme PR is merged, though at least the texture is likely fixed there already as the style is now flatter.

@YeldhamDev YeldhamDev force-pushed the improve_tab_consistency branch from 833887f to a989dc0 Compare January 13, 2022 01:12
@YeldhamDev
Copy link
Member Author

@pycbouh Still, no harm and making it look nicer until that's finished. Besides, I'm going to backport that once this is merged.

Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if the issue is fixed in the new theme, it should be good for the custom themes, and separate _draw_tab function is more readable.

@akien-mga akien-mga requested a review from Calinou January 13, 2022 07:45
@akien-mga
Copy link
Member

@Calinou might want to give this a check before we merge (at least to be aware of the need to rebase the theme changes in #51159).

@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the improve_tab_consistency branch January 14, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants