Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move duplicate AutoWrap, Overrun and VisibleChar behavior enums to the TextServer. #62066

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 15, 2022

Move AutowrapMode, OverrunBehavior and VisibleCharactersBehavior enums to TextServer. These enums were originally introduced as part of the Label. But later were copied to the other controls.

This PR replaces multiple versions of the same enum in different controls, with the single version in the TextServer.

@bruvzg bruvzg added this to the 4.0 milestone Jun 15, 2022
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bruvzg bruvzg force-pushed the cleanup_ts_enums branch from 51df0ba to b5c96df Compare June 16, 2022 13:49
@bruvzg bruvzg marked this pull request as ready for review June 16, 2022 14:39
@bruvzg bruvzg requested review from a team as code owners June 16, 2022 14:39
@akien-mga akien-mga merged commit 2aec924 into godotengine:master Jun 16, 2022
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the cleanup_ts_enums branch June 16, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants