Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate NoiseTexture2D's icon #77550

Merged

Conversation

MewPurPur
Copy link
Contributor

@MewPurPur MewPurPur commented May 27, 2023

We forgot to rename the icon when we renamed NoiseTexture to NoiseTexture2D. Also optimizes it a bit (we didn't svg-clean it with everything else because it's not in editor/icons).

@YuriSizov YuriSizov added this to the 4.1 milestone May 27, 2023
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the references, this was done in #64864.

I assume we also need one for 3D, added in #76486? (That won't be cherry-pickable though).

@YuriSizov
Copy link
Contributor

Could you amend the commit message to state that it's the icon that you're reinstating, not the class?

@MewPurPur
Copy link
Contributor Author

MewPurPur commented May 27, 2023

Oh, I thought I did that already. Doned now.

@MewPurPur MewPurPur force-pushed the reinstate-noise-texture-icon branch from c16d694 to ac8a9df Compare May 27, 2023 19:38
@akien-mga akien-mga merged commit eb1fbec into godotengine:master May 29, 2023
@akien-mga
Copy link
Member

Thanks!

@MewPurPur MewPurPur deleted the reinstate-noise-texture-icon branch May 29, 2023 09:08
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants