Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Do not save default values of script properties in .tres files #80897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Core: Do not save default values of script properties in .tres files #80897

wants to merge 1 commit into from
+4 −0

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Aug 22, 2023 •
edited
Loading

@dalexeev dalexeev added this to the 4.2 milestone Aug 22, 2023
@dalexeev dalexeev requested a review from a team August 22, 2023 14:51
@stryker313 stryker313 mentioned this pull request Aug 22, 2023
Open
RandomShaper
RandomShaper reviewed Aug 22, 2023
View reviewed changes
Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PropertyUtils::get_property_default_value() is a comprehensive implementation for finding out the default value. This PR may be reworked around it (affecting code that it didn't touch initially, though).

@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 31, 2023
@dalexeev dalexeev modified the milestones: 4.3, 4.4 May 31, 2024
@dalexeev dalexeev mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomShaper RandomShaper RandomShaper left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug enhancement topic:core
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Saved resources will preserve default exported variable values
3 participants
@dalexeev @RandomShaper @AThousandShips