Add a Viewport method to get automatically computed 2D stretch transform #80965
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
viewport-add-get-stretch-scale-factor
branch
from
3ba9917 to
a08fcec
Compare
Sauermann
reviewed
Aug 25, 2023
Calinou
force-pushed
the
viewport-add-get-stretch-scale-factor
branch
2 times, most recently
from
91fdbfd to
b0ce67a
Compare
Calinou
force-pushed
the
viewport-add-get-stretch-scale-factor
branch
from
b0ce67a to
56e0ee6
Compare
Calinou
force-pushed
the
viewport-add-get-stretch-scale-factor
branch
from
56e0ee6 to
6f3203c
Compare
Sauermann
reviewed
Oct 2, 2024
Calinou
force-pushed
the
viewport-add-get-stretch-scale-factor
branch
from
6f3203c to
41d1342
Compare
Geometror
approved these changes
Nov 19, 2024
Geometror
reviewed
Nov 19, 2024
`Viewport.get_stretch_transform()` returns the automatically computed 2D stretch transform. Combined with `Transform2D.get_scale()`, this is useful when using the `canvas_items` stretch mode in a project. There are many situations where knowing this factor is useful: - Divide Camera2D zoom to keep the size of the 2D game world identical regardless of the 2D scale factor (so that UI elements can still be scaled). - Make certain controls always drawn at 1:1 scale (e.g. for the crosshair in a FPS). This is done by dividing the Control node's scale by the scale factor.
Calinou
force-pushed
the
viewport-add-get-stretch-scale-factor
branch
from
41d1342 to
0cf99cf
Compare
Calinou
changed the title
|
I've force-pushed a commit that amends the commit message to describe more accurately what it does now (expose the stretch transform, not just the scale). |
Sauermann
approved these changes
Nov 19, 2024
|
Thanks! |
akien-mga
changed the title
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Viewport.get_stretch_transform()returns the automatically computed 2D stretch transform. Combined withTransform2D.get_scale(), this is useful when using thecanvas_itemsstretch mode in a project.There are many situations where knowing this factor is useful:
Testing project: test_scale_factor_2.zip
Preview
Top displays a GDScript implementation as shown in the proposal. Bottom displays the new implementation.