From 4ed51933f910b9dcfbe5b847c1d0b95e822fc0dd Mon Sep 17 00:00:00 2001 From: aaronp64 Date: Sat, 13 Apr 2024 14:03:29 -0400 Subject: [PATCH] Fix Window.hide() crash when force_native changed Moved force_native = p_force_native assignment to after is_visible() check, to prevent value from changing after window is shown. Fixes #90609 --- scene/main/window.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scene/main/window.cpp b/scene/main/window.cpp index 65f1365e679f..de6bc29f0538 100644 --- a/scene/main/window.cpp +++ b/scene/main/window.cpp @@ -1215,10 +1215,10 @@ void Window::set_force_native(bool p_force_native) { if (force_native == p_force_native) { return; } - force_native = p_force_native; if (is_visible() && !is_in_edited_scene_root()) { - WARN_PRINT("Can't change \"force_native\" while a window is displayed. Consider hiding window before changing this value."); + ERR_FAIL_MSG("Can't change \"force_native\" while a window is displayed. Consider hiding window before changing this value."); } + force_native = p_force_native; } bool Window::get_force_native() const {