-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded quotes from autocomplete % nodes #96666
Conversation
The change makes sense and works. Could you maybe add a test case for it? |
Removes unnecessary quotes for suggestions like $"%MyNode".
5faed09
to
2525311
Compare
I tried to add a test, but I'm not sure if I did it right and if the location and name makes sense. For some reason I can't run tests locally (I did build with |
The test looks good to me and passes in CI, so you did it right 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (still needs an official review though)
Thanks for reviewing and also for your work with autocompletion, I think it's the feature that makes or breaks the code editor 👍 |
By the way, do we have existing test case for $ operator's autocompletion? For basic case ( |
I was looking for some when I tried to link you to a location to add them and didn't find something. That being said, I'm currently changing something about the test runner, tests will probably be compatible but I wouldn't invest time into it before the new behavior is in. |
Gotchu. If you want, CC me once the changes are in, I can do it afterwards :) |
Thanks! |
Removes unnecessary quotes for suggestions like $"%MyNode".