Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGES: Support verify ethereum signature #561

Merged
merged 16 commits into from
Feb 9, 2022
Merged

BREAKING CHANGES: Support verify ethereum signature #561

merged 16 commits into from
Feb 9, 2022

Conversation

jjyr
Copy link
Collaborator

@jjyr jjyr commented Jan 20, 2022 •
edited
Loading

changes:

  1. Update godwoken.mol
    1. Add a new field compatible_chain_id: Uint32 to RollupConfig
    2. Change few structures from table to struct.
  2. Support Ethereum transaction signature by reverting 68d4e7c
  3. Support signing withdrawal in EIP712 format.
  4. Remove SUDT pay fee support.(SUDTTransfer can still pay fee in SUDT)

@jjyr jjyr marked this pull request as draft January 23, 2022 15:18
@jjyr jjyr force-pushed the support-verify-ethereum-signature branch 3 times, most recently from 25f981e to 846300a Compare January 28, 2022 05:36
@jjyr jjyr requested review from zeroqn and Flouse January 28, 2022 08:06
@jjyr jjyr marked this pull request as ready for review January 28, 2022 08:06
@jjyr jjyr force-pushed the support-verify-ethereum-signature branch from 0311479 to 1a79755 Compare January 29, 2022 02:13
@jjyr jjyr force-pushed the support-verify-ethereum-signature branch from 2ad77ca to 5f4ad43 Compare January 29, 2022 11:34
@jjyr jjyr requested a review from zeroqn January 30, 2022 05:58
@jjyr jjyr force-pushed the support-verify-ethereum-signature branch from 5f4ad43 to a2e24fb Compare January 30, 2022 06:08
jjyr added 14 commits February 7, 2022 16:03
@jjyr jjyr force-pushed the support-verify-ethereum-signature branch from 008817f to a43a003 Compare February 7, 2022 08:17
@jjyr jjyr merged commit e646d8a into godwokenrises:compatibility-breaking-changes Feb 9, 2022
@Flouse Flouse mentioned this pull request Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse approved these changes

@zeroqn zeroqn Awaiting requested review from zeroqn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjyr @Flouse @zeroqn