Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove helm chart UI #18099

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Remove helm chart UI #18099

merged 1 commit into from
Feb 8, 2023

Conversation

AllForNothing
Copy link
Contributor

@AllForNothing AllForNothing commented Jan 13, 2023 •
edited
Loading

  1. Remove all helm chart v2 related code for Remove chartmuseum support  #17958

Signed-off-by: AllForNothing sshijun@vmware.com

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@AllForNothing AllForNothing requested a review from a team as a code owner January 13, 2023 04:41
@AllForNothing AllForNothing added release-note/deprecation Harbor Deprecation MUST need to be in release notes target/2.8.0 labels Jan 13, 2023
@AllForNothing AllForNothing added the doc-impact Engineering issues that will require a change in user docs label Jan 13, 2023
@AllForNothing AllForNothing force-pushed the validator-check branch 2 times, most recently from acc7567 to cfe86ea Compare January 13, 2023 04:56
@codecov
Copy link

codecov bot commented Jan 13, 2023 •
edited
Loading

Codecov Report

Merging #18099 (9fc4f89) into main (9d30955) will increase coverage by 0.32%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18099      +/-   ##
==========================================
+ Coverage   43.98%   44.30%   +0.32%     
==========================================
  Files         245      232      -13     
  Lines       13410    12791     -619     
  Branches     2679     2577     -102     
==========================================
- Hits         5898     5667     -231     
+ Misses       7226     6841     -385     
+ Partials      286      283       -3
Flag Coverage Δ
unittests 44.30% <38.46%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ortal/src/app/account/sign-in/sign-in.component.ts 54.36% <ø> (+0.59%) ⬆️
src/portal/src/app/app.component.ts 73.68% <ø> (-1.32%) ⬇️
...rc/app/base/harbor-shell/harbor-shell.component.ts 64.77% <ø> (-0.40%) ⬇️
...av/projects/list-project/list-project.component.ts 27.43% <ø> (-0.44%) ⬇️
...v/replication/replication/replication.component.ts 23.83% <ø> (ø)
...av/replication/total-replication-page.component.ts 57.69% <ø> (-1.57%) ⬇️
...ide-nav/system-robot-accounts/system-robot-util.ts 65.78% <ø> (-1.72%) ⬇️
src/portal/src/app/base/project/project.ts 100.00% <ø> (ø)
...t/repository/artifact/artifact-additions/models.ts 100.00% <ø> (ø)
...oute-reuse-strategy/harbor-route-reuse-strategy.ts 28.26% <ø> (ø)
... and 19 more

wy65701436
wy65701436 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AllForNothing
Remove helm chart UI
9fc4f89 
    1.Remove all helm chart v2 related code

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing merged commit ff9dcd5 into goharbor:main Feb 8, 2023
tpoxa pushed a commit to container-registry/harbor that referenced this pull request Feb 8, 2023
@AllForNothing
Remove helm chart UI (goharbor#18099)
fbb4ec2 
1.Remove all helm chart v2 related code

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Maksym <maksym@container-registry.com>
mcsage pushed a commit to mcsage/harbor that referenced this pull request Feb 16, 2023
@AllForNothing
Remove helm chart UI (goharbor#18099)
bccf08d 
1.Remove all helm chart v2 related code

Signed-off-by: AllForNothing <sshijun@vmware.com>
Signed-off-by: Stephan Hohn <stephan.hohn@tech11.com>
sebglon pushed a commit to sebglon/harbor that referenced this pull request Mar 6, 2023
@AllForNothing @sebglon
Remove helm chart UI (goharbor#18099)
c4b305a 
1.Remove all helm chart v2 related code

Signed-off-by: AllForNothing <sshijun@vmware.com>
@AllForNothing AllForNothing deleted the validator-check branch March 29, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyyw zyyw zyyw approved these changes

@wy65701436 wy65701436 wy65701436 approved these changes

Assignees

@AllForNothing AllForNothing

Labels
doc-impact Engineering issues that will require a change in user docs release-note/deprecation Harbor Deprecation MUST need to be in release notes target/2.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AllForNothing @wy65701436 @zyyw @OrlinVasilev @chlins