markup: Add tabindex="0" to default <pre> wrapper. #8568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the generated
<pre>
element isn't fully accessible as it can't be focused by keyboard users.An example of syntax highlighting and how the aXe devTools extension detects this issue:
Additional info:
To make this fully accessible, the attribute
tabindex="0"
should be added to the<pre>
tag.According to MDN's page on tabindex the attribute can have 3 values:
-1
, which means "skip it using sequential tabbing"0
, focusable with sequential keyboard navigation (what we want in this case)Closes #7194
See also alecthomas/chroma#514