fixup! fix: #89

Signed-off-by: Yoan Blanc <yblanc@edgelab.ch>
gojek · Sep 16, 2020 · bbfba3c · bbfba3c
1 parent c6b32d9
commit bbfba3c
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/httpclient/client.go b/httpclient/client.go
@@ -177,15 +177,19 @@ outter:
 		if err != nil {
 			multiErr.Push(err.Error())
 			c.reportError(request, err)
-		} else {
-			c.reportRequestEnd(request, response)
+
+			continue
 		}
 
-		if err == nil && response.StatusCode < http.StatusInternalServerError {
-			// Clear errors if any iteration succeeds
-			multiErr = &valkyrie.MultiError{}
-			break
+		c.reportRequestEnd(request, response)
+
+		if response.StatusCode >= http.StatusInternalServerError {
+			continue
 		}
+
+		// Clear errors if any iteration succeeds
+		multiErr = &valkyrie.MultiError{}
+		break
 	}
 
 	return response, multiErr.HasError()