fix: change how queries are invalidated

Author: goknsh

.changeset/gorgeous-rings-invent.md

@@ -0,0 +1,5 @@
+---
+'svelte-query-pocketbase': patch
+---
+
+fix: change how queries are invalidated

src/lib/queries/collection.ts

@@ -179,10 +179,15 @@ export const createCollectionQuery = <
 						await unsubscribePromise
 					)();
 					if (
-						!collection.client.realtime['hasSubscriptionListeners'](collection.collectionIdOrName)
+						!collection.client.realtime['hasSubscriptionListeners'](
+							collection.collectionIdOrName
+						) ||
+						Object.keys(queryParams ?? {}).length > 0
 					) {
 						console.log(
-							`(C) ${JSON.stringify(queryKey)}: no realtime listeners, marking query as stale.`
+							`(C) ${JSON.stringify(
+								queryKey
+							)}: no realtime listeners or query has queryParams, marking query as stale.`
 						);
 						queryClient.invalidateQueries({ queryKey, exact: true });
 					}

src/lib/queries/infinite-collection.ts

@@ -303,14 +303,8 @@ export const createInfiniteCollectionQuery = <
 					await (
 						await unsubscribePromise
 					)();
-					if (
-						!collection.client.realtime['hasSubscriptionListeners'](collection.collectionIdOrName)
-					) {
-						console.log(
-							`(IC) ${JSON.stringify(queryKey)}: no realtime listeners, marking query as stale.`
-						);
-						queryClient.invalidateQueries({ queryKey, exact: true });
-					}
+					console.log(`(IC) ${JSON.stringify(queryKey)}: marking query as stale.`);
+					queryClient.invalidateQueries({ queryKey, exact: true });
 				})();
 				return unsubscriber();
 			};

src/lib/queries/record.ts

@@ -172,11 +172,17 @@ export const createRecordQuery = <
 					if (
 						!collection.client.realtime['hasSubscriptionListeners'](
 							`${collection.collectionIdOrName}/${id}`
-						)
+						) ||
+						Object.keys(queryParams ?? {}).length > 0
 					) {
 						console.log(
-							`(R) ${JSON.stringify(queryKey)}: no realtime listeners, marking query as stale.`
+							`(R) ${JSON.stringify(
+								queryKey
+							)}: no realtime listeners or query has queryParams, marking query as stale.`
 						);
+						// todo: correctly derive queryKey to mark as invalid
+						// todo: ensure that if a $store was passed into filterFunction,
+						// only the value when query was created with is used even after the $store's value changes
 						queryClient.invalidateQueries({ queryKey, exact: true });
 					}
 				})();