From 6071bf9f5859d27104e2586de04dcd8df27c9a95 Mon Sep 17 00:00:00 2001 From: Aaron Bieber Date: Thu, 19 Jan 2023 07:23:16 -0700 Subject: [PATCH] dashboard: remove openbsd-{386,amd64}-71 OpenBSD 7.1 has a kqueue bug[1] that prevents these builders from working properly. [1] https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/kern/kern_event.c.diff?r1=1.188&r2=1.189 --- dashboard/builders.go | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/dashboard/builders.go b/dashboard/builders.go index 8de40a2e7e..8707bd21d6 100644 --- a/dashboard/builders.go +++ b/dashboard/builders.go @@ -451,13 +451,6 @@ var Hosts = map[string]*HostConfig{ Owners: []*gophers.Person{gh("bsiegert")}, GoBootstrap: "go1.19.2", // Go 1.17 is too old; see go.dev/issue/42422 }, - "host-openbsd-386-71": { - VMImage: "openbsd-386-71", - machineType: "n2", // force Intel; see go.dev/issue/49209 - Notes: "OpenBSD 7.1; GCE VM, built from build/env/openbsd-386", - SSHUsername: "gopher", - GoBootstrap: "go1.19.2", // Go 1.17 is too old; see go.dev/issue/42422 - }, "host-openbsd-386-72": { VMImage: "openbsd-386-72", machineType: "n2", // force Intel; see go.dev/issue/49209 @@ -465,13 +458,6 @@ var Hosts = map[string]*HostConfig{ SSHUsername: "gopher", GoBootstrap: "go1.19.2", // Go 1.17 is too old; see go.dev/issue/42422 }, - "host-openbsd-amd64-71": { - VMImage: "openbsd-amd64-71", - machineType: "n2", // force Intel; see go.dev/issue/49209 - Notes: "OpenBSD 7.1; GCE VM, built from build/env/openbsd-amd64", - SSHUsername: "gopher", - GoBootstrap: "go1.19.2", // Go 1.17 is too old; see go.dev/issue/42422 - }, "host-openbsd-amd64-72": { VMImage: "openbsd-amd64-72", machineType: "n2", // force Intel; see go.dev/issue/49209 @@ -1965,12 +1951,6 @@ func init() { "GO_DISABLE_OUTBOUND_NETWORK=1", }, }) - addBuilder(BuildConfig{ - Name: "openbsd-amd64-71", - HostType: "host-openbsd-amd64-71", - distTestAdjust: noTestDirAndNoReboot, - numTryTestHelpers: 4, - }) addBuilder(BuildConfig{ Name: "openbsd-amd64-72", HostType: "host-openbsd-amd64-72", @@ -1978,17 +1958,6 @@ func init() { distTestAdjust: noTestDirAndNoReboot, numTryTestHelpers: 4, }) - addBuilder(BuildConfig{ - Name: "openbsd-386-71", - HostType: "host-openbsd-386-71", - buildsRepo: func(repo, branch, goBranch string) bool { - // https://go.dev/issue/49529: git seems to be too slow on this - // platform. - return repo != "review" && buildRepoByDefault(repo) - }, - distTestAdjust: noTestDirAndNoReboot, - numTryTestHelpers: 4, - }) addBuilder(BuildConfig{ Name: "openbsd-386-72", HostType: "host-openbsd-386-72",