From 035c018d40c0a7895880e235048d425ea3e3fa6b Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Wed, 11 Mar 2020 09:39:54 -0400 Subject: [PATCH] runtime: skip TestSignalIgnoreSIGTRAP on known-flaky OpenBSD builders This test is flaky, and the cause is suspected to be an OpenBSD kernel bug. Since there is no obvious workaround on the Go side, skip the test on builders whose versions are known to be affected. Fixes #17496 Change-Id: Ifa70061eb429e1d949f0fa8a9e25d177afc5c488 Reviewed-on: https://go-review.googlesource.com/c/go/+/222856 Run-TryBot: Bryan C. Mills TryBot-Result: Gobot Gobot Reviewed-by: Alexander Rakoczy --- src/runtime/crash_unix_test.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/runtime/crash_unix_test.go b/src/runtime/crash_unix_test.go index 1420b3206acd1..8ef52aba48f15 100644 --- a/src/runtime/crash_unix_test.go +++ b/src/runtime/crash_unix_test.go @@ -15,6 +15,7 @@ import ( "os/exec" "path/filepath" "runtime" + "strings" "sync" "syscall" "testing" @@ -288,6 +289,12 @@ func TestSignalExitStatus(t *testing.T) { } func TestSignalIgnoreSIGTRAP(t *testing.T) { + if runtime.GOOS == "openbsd" { + if bn := testenv.Builder(); strings.HasSuffix(bn, "-62") || strings.HasSuffix(bn, "-64") { + testenv.SkipFlaky(t, 17496) + } + } + output := runTestProg(t, "testprognet", "SignalIgnoreSIGTRAP") want := "OK\n" if output != want {