From 25c6dce1882795b64988bdf634282e7512842650 Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Thu, 10 Aug 2023 01:51:17 +0700 Subject: [PATCH] [release-branch.go1.21] cmd/compile: make backingArrayPtrLen to return typecheck-ed nodes Fixes #61909 Change-Id: Ief8e3a6c42c0644c9f71ebef5f28a294cd7c153f Reviewed-on: https://go-review.googlesource.com/c/go/+/517936 Run-TryBot: Cuong Manh Le Auto-Submit: Cuong Manh Le TryBot-Result: Gopher Robot Reviewed-by: Matthew Dempsky Reviewed-by: Michael Knyszek Reviewed-on: https://go-review.googlesource.com/c/go/+/518115 Auto-Submit: Dmitri Shuralyov --- src/cmd/compile/internal/walk/walk.go | 2 ++ test/fixedbugs/issue61908.go | 16 ++++++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 test/fixedbugs/issue61908.go diff --git a/src/cmd/compile/internal/walk/walk.go b/src/cmd/compile/internal/walk/walk.go index 778b95d5473569..149e23ab7c1626 100644 --- a/src/cmd/compile/internal/walk/walk.go +++ b/src/cmd/compile/internal/walk/walk.go @@ -278,8 +278,10 @@ func backingArrayPtrLen(n ir.Node) (ptr, length ir.Node) { } else { ptr.SetType(n.Type().Elem().PtrTo()) } + ptr.SetTypecheck(1) length = ir.NewUnaryExpr(base.Pos, ir.OLEN, n) length.SetType(types.Types[types.TINT]) + length.SetTypecheck(1) return ptr, length } diff --git a/test/fixedbugs/issue61908.go b/test/fixedbugs/issue61908.go new file mode 100644 index 00000000000000..f5d3bce678b09b --- /dev/null +++ b/test/fixedbugs/issue61908.go @@ -0,0 +1,16 @@ +// compile + +// Copyright 2023 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package p + +func f(p []byte) int { + switch "" < string(p) { + case true: + return 0 + default: + return 1 + } +}