From 2ca4104f0519027c55266d48b47ea16ee4da6915 Mon Sep 17 00:00:00 2001 From: cui fliter Date: Thu, 4 May 2023 19:30:53 +0800 Subject: [PATCH] cmd: use slices.Equal to simplify code #57433 added slices.Equal, using it can reduce the amount of code Change-Id: I70d14b6c4c24da641a34ed36c900d9291033f526 Reviewed-on: https://go-review.googlesource.com/c/go/+/492576 Reviewed-by: Than McIntosh TryBot-Result: Gopher Robot Run-TryBot: Ian Lance Taylor Reviewed-by: Ian Lance Taylor Auto-Submit: Ian Lance Taylor Run-TryBot: shuang cui --- src/cmd/covdata/argsmerge.go | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/src/cmd/covdata/argsmerge.go b/src/cmd/covdata/argsmerge.go index f591e3abd4049..8af1432d62ad3 100644 --- a/src/cmd/covdata/argsmerge.go +++ b/src/cmd/covdata/argsmerge.go @@ -6,6 +6,7 @@ package main import ( "fmt" + "slices" "strconv" ) @@ -20,25 +21,13 @@ type argstate struct { initialized bool } -func ssleq(s1 []string, s2 []string) bool { - if len(s1) != len(s2) { - return false - } - for i := range s1 { - if s1[i] != s2[i] { - return false - } - } - return true -} - func (a *argstate) Merge(state argvalues) { if !a.initialized { a.state = state a.initialized = true return } - if !ssleq(a.state.osargs, state.osargs) { + if !slices.Equal(a.state.osargs, state.osargs) { a.state.osargs = nil } if state.goos != a.state.goos {