Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2: pool deadlock [1.17 backport] #48650

Closed
gopherbot opened this issue Sep 27, 2021 · 3 comments
Closed

x/net/http2: pool deadlock [1.17 backport] #48650

gopherbot opened this issue Sep 27, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.3

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #32388 to be considered for backport to the next 1.17 minor release.

@gopherbot Please open backport issues.

This appears to be an occasional deadlock in http. Should be considered for backporting depending on what @neild thinks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Sep 27, 2021
@gopherbot gopherbot mentioned this issue Sep 27, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.2 milestone Sep 27, 2021
@heschi heschi added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Oct 6, 2021
@mknyszek mknyszek modified the milestones: Go1.17.2, Go1.17.3 Oct 7, 2021
@adriansmares adriansmares mentioned this issue Oct 26, 2021
Open
@dmitshur
Copy link
Contributor

This is a subset of #49077 and will be resolved by CL 357677.

@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/359776 mentions this issue: [release-branch.go1.17] net/http: update bundled golang.org/x/net/http2

@gopherbot
Copy link
Contributor Author

Closed by merging f9cb33c to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Nov 1, 2021
@dmitshur
[release-branch.go1.17] net/http: update bundled golang.org/x/net/http2
f9cb33c 
Pull in approved backports to golang.org/x/net/http2:

	95aca89 set ContentLength to -1 for HEAD response with no Content-Length
	bd5b1b8 set Response.ContentLength to 0 when headers end stream
	27001ec don't abort half-closed streams on server connection close
	f0a8156 on write errors, close ClientConn before returning from RoundTrip
	9a182eb deflake TestTransportReqBodyAfterResponse_200
	821db7b close the Request's Body when aborting a stream
	028e125 return unexpected eof on empty response with non-zero content length
	5388f2f don't rely on system TCP buffer sizes in TestServer_MaxQueuedControlFrames
	fc298ce detect write-blocked PING frames
	e96ad84 avoid race in TestTransportReqBodyAfterResponse_403.
	7f15435 avoid clientConnPool panic when NewClientConn fails
	9572bae avoid extra GetConn trace call
	b04064c refactor request write flow
	7e165c9 remove PingTimeout from TestTransportPingWhenReading
	ef976fc fix Transport connection pool TOCTOU max concurrent stream bug
	1d9597c shut down idle Transport connections after protocol errors
	c173d09 remove check for read-after-close of request bodies
	466a463 fix race in DATA frame padding refund
	4028c5f avoid blocking while holding ClientConn.mu
	b91f72d fix off-by-one error in client check for max concurrent streams
	21e6c63 close request body after early RoundTrip failures
	e79adf9 limit client initial MAX_CONCURRENT_STREAMS
	c0c2bc5 make Transport not reuse conns after a stream protocol error
	14c0235 accept zero-length block fragments in HEADERS frames
	0d2c43c close the request body if needed
	5627bb0 reduce frameScratchBuffer caching aggressiveness
	c9f4fb0 also set "http/1.1" ALPN in ConfigureServer

By doing:

	$ go get -d golang.org/x/net@internal-branch.go1.17-vendor
	go get: upgraded golang.org/x/net v0.0.0-20210901185426-6d2eada6345e => v0.0.0-20211101194204-95aca89e93de
	$ go mod tidy
	$ go mod vendor
	$ go generate -run=bundle std

Fixes #49077.
Fixes #48823.
Fixes #48650.

Change-Id: Idb972ba5313080626b60b4111d52b80197364ff4
Reviewed-on: https://go-review.googlesource.com/c/go/+/359776
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
@leighmcculloch leighmcculloch mentioned this issue Jan 3, 2022
Closed
@golang golang locked and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.3
Development

No branches or pull requests
4 participants
@mknyszek @dmitshur @gopherbot @heschi