x/website/cmd/golangorg: frequent TestWeb failures with "connect: no route to host" to play.golang.org since CL 388016 #51439

bcmills · 2022-03-02T19:28:27Z

2022/03/02 11:56:35 readVersions: Get "https://play.golang.org/versions": dial tcp 142.250.148.141:443: connect: no route to host
2022/03/02 11:56:35 newDirTree reading src: open src: no file system
2022/03/02 11:56:38 ERROR share error: Get "https://play.golang.org/p/MAohLsrz7JQ.go": dial tcp 142.250.148.141:443: connect: no route to host
2022/03/02 11:56:38 https://go.dev/
--- FAIL: TestWeb (5.18s)
    --- FAIL: TestWeb/godev.txt (0.16s)
        --- FAIL: TestWeb/godev.txt/GET/https://go.dev/play/p/MAohLsrz7JQ.go (0.01s)
            webtest.go:260: testdata/godev.txt:46: GET https://go.dev/play/p/MAohLsrz7JQ.go
                testdata/godev.txt:50: body does not contain `Hello, 世界` (but should)
                	Internal Server Error
                testdata/godev.txt:47: code = "500", want "200"
                
2022/03/02 11:56:41 newDirTree reading src: open src: no file system
FAIL
FAIL	golang.org/x/website/cmd/golangorg	15.760s

These failures appear to have started as of CL 388016 (attn @jamalc, @dmitshur).
We should probably either roll back that CL or skip the test until the cause of the failure can be diagnosed and fixed.

@golang/release, we may also want to investigate whether this indicates a problem with the builders' network connectivity, the go.dev server, and/or the play.golang.org server.

greplogs --dashboard -md -l -e 'connect: no route to host\n(?:.*\n)*FAIL\s+golang\.org/x/website/cmd/.*'

The text was updated successfully, but these errors were encountered:

dmitshur · 2022-03-02T20:44:00Z

From looking at the build dashboard, this failure isn't just frequent, it happens reproducibly since the test case in CL 388016 was added. And it only happens on linux-{386,amd64}-stretch builders, not any others.

There appears to be two separate issues uncovered here.

One, the tests cases that were added in CL 388016 should be moved to live.txt, since they depend on production resources. It just so happens these production resources are normally publicly accessibly when running tests locally, since they use "https://play.golang.org" URLs (as opposed to an internal resource only available to the go.dev server in production). I confirmed this locally by running tests with my internet disabled, as should be the case on many builders. Will send a CL to fix this. (Sent CL 389394.)

The other issue is that this is only caught by the linux-386-stretch and linux-amd64-stretch builders, but not any of the others. In x/build/dashboard, many more builders have GO_DISABLE_OUTBOUND_NETWORK=1 in their configuration, and this shows that might not be having effect on most builders. This needs more investigation. (Filed #51444 for this.)

gopherbot · 2022-03-02T21:06:58Z

Change https://go.dev/cl/389394 mentions this issue: cmd/golangorg: move test cases that need internet to live.txt

gopherbot · 2022-03-02T21:28:02Z

Change https://go.dev/cl/389394 mentions this issue: cmd/golangorg: move test case that needs internet to live.txt

One test case added in CL 388016 depends on production resources, specifically the snippet https://play.golang.org/p/MAohLsrz7JQ.go served by the production instance of the Go playground. This would be caught by TryBots where internet access is disabled, but that didn't happen due to golang/go#51444. Updates golang/go#51181. Fixes golang/go#51439. Change-Id: I4f1c5ea1a6ccad9ae4e5cbb749e3dee0b26731b5 Reviewed-on: https://go-review.googlesource.com/c/website/+/389394 Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com> Trust: Dmitri Shuralyov <dmitshur@google.com>

bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Mar 2, 2022

bcmills added this to the Go1.19 milestone Mar 2, 2022

dmitshur mentioned this issue Mar 2, 2022

x/build/dashboard: many builders are configured with GO_DISABLE_OUTBOUND_NETWORK=1, but it has effect only on linux-386-stretch, linux-amd64-stretch #51444

Closed

gopherbot closed this as completed in golang/website@42bfd6b Mar 2, 2022

golang locked and limited conversation to collaborators Mar 2, 2023

gopherbot added the FrozenDueToAge label Mar 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/website/cmd/golangorg: frequent TestWeb failures with "connect: no route to host" to play.golang.org since CL 388016 #51439

x/website/cmd/golangorg: frequent TestWeb failures with "connect: no route to host" to play.golang.org since CL 388016 #51439

bcmills commented Mar 2, 2022

dmitshur commented Mar 2, 2022 •

edited

Loading

gopherbot commented Mar 2, 2022

gopherbot commented Mar 2, 2022

x/website/cmd/golangorg: frequent TestWeb failures with "connect: no route to host" to play.golang.org since CL 388016 #51439

x/website/cmd/golangorg: frequent TestWeb failures with "connect: no route to host" to play.golang.org since CL 388016 #51439

Comments

bcmills commented Mar 2, 2022

dmitshur commented Mar 2, 2022 • edited Loading

gopherbot commented Mar 2, 2022

gopherbot commented Mar 2, 2022

dmitshur commented Mar 2, 2022 •

edited

Loading