Skip to content

misc/cgo/testsanitizers: deadlock in TestTSAN/tsan11 [1.18 backport] #53115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue May 27, 2022 · 3 comments
Closed

misc/cgo/testsanitizers: deadlock in TestTSAN/tsan11 [1.18 backport] #53115

gopherbot opened this issue May 27, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.18.3

Comments

@gopherbot
Copy link
Contributor

@bcmills requested issue #53113 to be considered for backport to the next 1.18 minor release.

@gopherbot, please backport to Go 1.18 and 1.17. This is a test-only fix for a spurious deadlock.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 27, 2022
@gopherbot gopherbot mentioned this issue May 27, 2022
Closed
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label May 27, 2022
@gopherbot gopherbot added this to the Go1.18.3 milestone May 27, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/408823 mentions this issue: [release-branch.go1.18] misc/cgo/testsanitizers: buffer the signal channel in TestTSAN/tsan11

@dmitshur
Copy link
Member

Approved as a safe, test-only fix, analogous to the recent one for TestTSAN/tsan12.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels May 30, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging da608a2 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 30, 2022
@dmitshur
[release-branch.go1.18] misc/cgo/testsanitizers: buffer the signal ch…
da608a2 
…annel in TestTSAN/tsan11

This fix is analogous to the one in CL 407888.

'go vet' catches the error, but it is not run on this file because the
file is (only) compiled when running testsanitizers/TestTSAN.

Fixes #53115.
Updates #53113.

Change-Id: I74f7b7390a9775ff00a06214c1019ba28846dd11
Reviewed-on: https://go-review.googlesource.com/c/go/+/409094
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
(cherry picked from commit 0f57c88)
Reviewed-on: https://go-review.googlesource.com/c/go/+/408823
Reviewed-by: Ian Lance Taylor <iant@google.com>
@golang golang locked and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.18.3
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot