http2: perform connection health check #55

caesarxuchao · 2019-10-01T00:33:50Z

After the connection has been idle for a while, periodic pings are sent
over the connection to check its health. Unhealthy connection is closed
and removed from the connection pool.

Fixes golang/go#31643

gopherbot · 2019-10-01T00:35:22Z

This PR (HEAD: bc0d6c6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-01T00:36:19Z

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-14T17:46:40Z

Message from Brad Fitzpatrick:

Patch Set 1:

(11 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-17T00:11:13Z

Message from Chao Xu:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-19T00:18:27Z

This PR (HEAD: 840ca83) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-19T00:20:45Z

This PR (HEAD: b2e6f87) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-10-19T00:22:45Z

Message from Chao Xu:

Patch Set 2:

Hi Brad,

Thank you for the review. I modified the periodic ping behavior to start only after the readloop has been idle for a while, and to stop once new frame is received in the readloop.

I have also addressed other comments.

PTAL. Thank you.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-10-19T00:23:42Z

Message from Chao Xu:

Patch Set 3:

Patch Set 2:

Hi Brad,

Thank you for the review. I modified the periodic ping behavior to start only after the readloop has been idle for a while, and to stop once new frame is received in the readloop.

I have also addressed other comments.

PTAL. Thank you.

I will be OOO until Oct. 30.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-11-21T17:53:42Z

Message from Brad Fitzpatrick:

Patch Set 3:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-11-22T07:57:24Z

This PR (HEAD: 331a10c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-11-22T18:35:13Z

Message from Brad Fitzpatrick:

Patch Set 4:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-11-22T19:58:39Z

Message from Daniel Smith:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-11-23T02:03:54Z

Message from Chao Xu:

Patch Set 4:

(4 comments)

Patch Set 4:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-11-23T02:05:11Z

This PR (HEAD: 5058c86) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-02-06T18:22:55Z

Message from Andrew Bonventre:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-02-07T05:47:01Z

Message from Michael Fraenkel:

Patch Set 5:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-02-07T13:17:29Z

Message from Michael Fraenkel:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-02-07T22:42:16Z

Message from Chao Xu:

Patch Set 5:

Thank you for the reviews. I'll address them the next week.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-02-21T00:45:52Z

This PR (HEAD: 231a5fe) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-02-21T00:47:13Z

Message from Chao Xu:

Patch Set 5:

(4 comments)

@michael, I managed to simplify the code a lot. See the inline replies. PTAL. Thank you for the review!

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-02-21T02:31:55Z

Message from Michael Fraenkel:

Patch Set 6:

(8 comments)

Glad there was some simplification to this.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-02-21T20:39:24Z

This PR (HEAD: ee11e85) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-02-21T20:40:41Z

Message from Chao Xu:

Patch Set 6:

(7 comments)

Thanks, Michael. PTAL.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-02-21T20:41:59Z

Message from Chao Xu:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-02-21T22:56:12Z

Message from Michael Fraenkel:

Patch Set 7:

(2 comments)

Just a few minor changes. Otherwise it looks much better.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-03-11T20:33:39Z

This PR (HEAD: bce9e97) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

After the connection has been idle for a while, periodic pings are sent over the connection to check its health. Unhealthy connection is closed and removed from the connection pool. Fixes golang/go#31643

gopherbot · 2020-03-11T20:59:08Z

This PR (HEAD: 36607fe) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/198040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2020-03-11T21:03:15Z

Message from Chao Xu:

Patch Set 16:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T16:51:59Z

Message from Russ Cox:

Patch Set 16: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T16:54:44Z

Message from Russ Cox:

Patch Set 16:

(16 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T16:56:12Z

Message from Russ Cox:

Patch Set 16:

(10 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T16:56:13Z

Message from Russ Cox:

Patch Set 16:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T16:57:44Z

Message from Russ Cox:

Patch Set 16: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T16:57:45Z

Message from Gobot Gobot:

Patch Set 16:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=74d0d8c3

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T16:57:46Z

Message from Russ Cox:

Patch Set 16:

If the trybots come back happy, this is OK to submit.

In the future, please mark resolved comments resolved, using Done or the checkbox. Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T16:57:47Z

Message from Gobot Gobot:

Patch Set 16:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/f7f9c8f2/freebsd-amd64-12_0_77064e88.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T17:00:47Z

Message from Gobot Gobot:

Patch Set 16: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T18:18:28Z

Message from Andrew Bonventre:

Patch Set 17: Patch Set 16 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T18:18:29Z

Message from Andrew Bonventre:

Patch Set 17: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T18:18:30Z

Message from Gobot Gobot:

Patch Set 17:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=f8b7a1fa

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2020-05-20T18:21:18Z

Message from Gobot Gobot:

Patch Set 17: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/198040.
After addressing review feedback, remember to publish your drafts!

After the connection has been idle for a while, periodic pings are sent over the connection to check its health. Unhealthy connection is closed and removed from the connection pool. Fixes golang/go#31643 Change-Id: Idbbc9cb2d3e26c39f84a33e945e482d41cd8583c GitHub-Last-Rev: 36607fe GitHub-Pull-Request: #55 Reviewed-on: https://go-review.googlesource.com/c/net/+/198040 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>

gopherbot · 2020-05-20T18:25:29Z

This PR is being closed because golang.org/cl/198040 has been merged.

torrescd · 2020-08-18T19:10:27Z

@gopherbot backport please 1.13

caesarxuchao · 2021-03-20T18:16:15Z

The readIdleTimeout is only reset if the client receives packets. So in the case you mentioned, even if the clients sends requests frequently, because it doesn't receive any packets, the healthCheck will still be fired and detects the broken connection.

…

On Mon, Mar 15, 2021 at 10:32 PM Kevin Wang ***@***.***> wrote: Many thanks for this! I've got one question though: If the application sends http2 requests more frequently than ReadIdleTimeout (e.g. ReadIdleTimeout=30s, application sends request every 10s), is it possible that, the application still gets "use of closed network connection" every 10s, while cc.healthCheck is never triggered (because it is never idle long enough)? f, err := cc.fr.ReadFrame()+ if t != nil {+ t.Reset(readIdleTimeout)+ } if err != nil { cc.vlogf("http2: Transport readFrame error on conn %p: (%T) %v", cc, err, err) } Maybe we should not Reset t? Or only reset t if there it is verified that there is no error? I'm probably wrong, please correct me if I'm wrong, thanks! @caesarxuchao <https://github.com/caesarxuchao> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#55 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVRK2I6NUVIN6XQOIVFBD3TD3UQVANCNFSM4I4CMFIA> .

-- Regards, Chao Xu

After the connection has been idle for a while, periodic pings are sent over the connection to check its health. Unhealthy connection is closed and removed from the connection pool. Fixes golang/go#31643 Change-Id: Idbbc9cb2d3e26c39f84a33e945e482d41cd8583c GitHub-Last-Rev: 36607fe185ce6684e9900403f82a298ad5567650 GitHub-Pull-Request: golang/net#55 Reviewed-on: https://go-review.googlesource.com/c/net/+/198040 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Russ Cox <rsc@golang.org>

googlebot added the cla: yes label Oct 1, 2019

ereslibre mentioned this pull request Oct 3, 2019

[WIP] Keep connection alive during streaming operations kubernetes/kubernetes#81179

Closed

ereslibre mentioned this pull request Oct 13, 2019

HA: improvements to the load balancer documentation kubernetes/kubeadm#1685

Closed

jqmichael mentioned this pull request Oct 17, 2019

Rolling upgrade breaks sidecar-injector webhook on EKS (failed calling admission webhook "sidecar-injector.istio.io": context deadline exceeded) istio/istio#13840

Closed

caesarxuchao force-pushed the ping-connection branch from 840ca83 to b2e6f87 Compare October 19, 2019 00:19

net/http2: perform connection health check

36607fe

After the connection has been idle for a while, periodic pings are sent over the connection to check its health. Unhealthy connection is closed and removed from the connection pool. Fixes golang/go#31643

caesarxuchao force-pushed the ping-connection branch from bce9e97 to 36607fe Compare March 11, 2020 20:58

caesarxuchao mentioned this pull request Apr 2, 2020

(1.17) Kubelet won't reconnect to Apiserver after NIC failure (use of closed network connection) kubernetes/kubernetes#87615

Closed

caesarxuchao mentioned this pull request Apr 19, 2020

Client should expose a mechanism to close underlying TCP connections kubernetes/client-go#374

Closed

gopherbot closed this May 20, 2020

prateekpandey14 mentioned this pull request May 21, 2020

failed calling webhook "admission-webhook.openebs.io": Post https://admission-server-svc.openebs.svc:443/validate?timeout=5s: context deadline exceeded openebs/openebs#3046

Closed

This was referenced Jul 14, 2020

x/net/http2: ReadIdleTimeout/PingTimeout not exposed if configured through http package golang/go#40201

Closed

Prometheus should use http2 health monitor/set http2 ReadIdleTimeout prometheus/prometheus#7588

Closed

clshortfuse mentioned this pull request Apr 13, 2022

Default http[2s] server timeout is problematic nodejs/node#27556

Closed

http2: perform connection health check #55

http2: perform connection health check #55

Conversation

caesarxuchao commented Oct 1, 2019 • edited Loading

gopherbot commented Oct 1, 2019

gopherbot commented Oct 1, 2019

gopherbot commented Oct 14, 2019

gopherbot commented Oct 17, 2019

gopherbot commented Oct 19, 2019

gopherbot commented Oct 19, 2019

gopherbot commented Oct 19, 2019

gopherbot commented Oct 19, 2019

gopherbot commented Nov 21, 2019

gopherbot commented Nov 22, 2019

gopherbot commented Nov 22, 2019

gopherbot commented Nov 22, 2019

gopherbot commented Nov 23, 2019

gopherbot commented Nov 23, 2019

gopherbot commented Feb 6, 2020

gopherbot commented Feb 7, 2020

gopherbot commented Feb 7, 2020

gopherbot commented Feb 7, 2020

gopherbot commented Feb 21, 2020

gopherbot commented Feb 21, 2020

gopherbot commented Feb 21, 2020

gopherbot commented Feb 21, 2020

gopherbot commented Feb 21, 2020

gopherbot commented Feb 21, 2020

gopherbot commented Feb 21, 2020

gopherbot commented Mar 11, 2020

gopherbot commented Mar 11, 2020

gopherbot commented Mar 11, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

gopherbot commented May 20, 2020

torrescd commented Aug 18, 2020

caesarxuchao commented Mar 20, 2021 via email

caesarxuchao commented Oct 1, 2019 •

edited

Loading