dev: option to not check deprecation

Author: ldez

.golangci.yml

@@ -159,20 +159,11 @@ issues:
     - path: pkg/commands/run.go
       linters: [staticcheck]
       text: "SA1019: c.cfg.Run.ShowStats is deprecated: use Output.ShowStats instead."
-    - path: pkg/commands/config.go
-      linters: [staticcheck]
-      text: "SA1019: cfg.Run.UseDefaultSkipDirs is deprecated: use Issues.UseDefaultExcludeDirs instead."
-    - path: pkg/commands/linters.go
-      linters: [staticcheck]
-      text: "SA1019: c.cfg.Run.UseDefaultSkipDirs is deprecated: use Issues.UseDefaultExcludeDirs instead."
 
     # Deprecated linter options.
     - path: pkg/golinters/errcheck.go
       linters: [staticcheck]
       text: "SA1019: errCfg.Exclude is deprecated: use ExcludeFunctions instead"
-    - path: pkg/commands/run.go
-      linters: [staticcheck]
-      text: "SA1019: lsc.Errcheck.Exclude is deprecated: use ExcludeFunctions instead"
     - path: pkg/golinters/govet.go
       linters: [staticcheck]
       text: "SA1019: cfg.CheckShadowing is deprecated: the linter should be enabled inside Enable."

pkg/commands/config.go

@@ -82,16 +82,10 @@ func (c *configCommand) preRunE(cmd *cobra.Command, args []string) error {
 	// It only needs to know the path of the configuration file.
 	cfg := config.NewDefault()
 
-	// Hack to hide deprecation messages related to `--skip-dirs-use-default`:
-	// Flags are not bound then the default values, defined only through flags, are not applied.
-	// In this command, file path and file information are the only requirements, i.e. it don't need flag values.
-	//
-	// TODO(ldez) add an option (check deprecation) to `Loader.Load()` but this require a dedicated PR.
-	cfg.Run.UseDefaultSkipDirs = true
-
 	loader := config.NewLoader(c.log.Child(logutils.DebugKeyConfigReader), c.viper, cmd.Flags(), c.opts, cfg, args)
 
-	if err := loader.Load(); err != nil {
+	err := loader.Load(config.LoadOptions{})
+	if err != nil {
 		return fmt.Errorf("can't load config: %w", err)
 	}
 

pkg/commands/linters.go

@@ -59,16 +59,10 @@ func newLintersCommand(logger logutils.Log) *lintersCommand {
 }
 
 func (c *lintersCommand) preRunE(cmd *cobra.Command, args []string) error {
-	// Hack to hide deprecation messages related to `--skip-dirs-use-default`:
-	// Flags are not bound then the default values, defined only through flags, are not applied.
-	// In this command, linters information are the only requirements, i.e. it don't need flag values.
-	//
-	// TODO(ldez) add an option (check deprecation) to `Loader.Load()` but this require a dedicated PR.
-	c.cfg.Run.UseDefaultSkipDirs = true
-
 	loader := config.NewLoader(c.log.Child(logutils.DebugKeyConfigReader), c.viper, cmd.Flags(), c.opts.LoaderOptions, c.cfg, args)
 
-	if err := loader.Load(); err != nil {
+	err := loader.Load(config.LoadOptions{})
+	if err != nil {
 		return fmt.Errorf("can't load config: %w", err)
 	}
 

pkg/commands/run.go

@@ -154,7 +154,8 @@ func (c *runCommand) persistentPreRunE(cmd *cobra.Command, args []string) error
 
 	loader := config.NewLoader(c.log.Child(logutils.DebugKeyConfigReader), c.viper, cmd.Flags(), c.opts.LoaderOptions, c.cfg, args)
 
-	if err := loader.Load(); err != nil {
+	err := loader.Load(config.LoadOptions{CheckDeprecation: true})
+	if err != nil {
 		return fmt.Errorf("can't load config: %w", err)
 	}
 

pkg/config/loader.go

@@ -24,6 +24,10 @@ type LoaderOptions struct {
 	NoConfig bool   // Flag only.
 }
 
+type LoadOptions struct {
+	CheckDeprecation bool
+}
+
 type Loader struct {
 	opts LoaderOptions
 
@@ -47,7 +51,7 @@ func NewLoader(log logutils.Log, v *viper.Viper, fs *pflag.FlagSet, opts LoaderO
 	}
 }
 
-func (l *Loader) Load() error {
+func (l *Loader) Load(opts LoadOptions) error {
 	err := l.setConfigFile()
 	if err != nil {
 		return err
@@ -60,9 +64,11 @@ func (l *Loader) Load() error {
 
 	l.applyStringSliceHack()
 
-	err = l.handleDeprecation()
-	if err != nil {
-		return err
+	if opts.CheckDeprecation {
+		err = l.handleDeprecation()
+		if err != nil {
+			return err
+		}
 	}
 
 	l.handleGoVersion()