This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
use the existing instance of Velocity instead of requiring a new one #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this, velocity-react was always requiring a new instance of velocity-animate, so require('velocity-animate/velocity-ui') was attaching to the wrong instance. This finds an existing instance the correct way (the same way velocity.ui.js does it)
|
Makes sense. Thanks for putting this together. |
fionawhim
added a commit
that referenced
this pull request
Oct 21, 2015
use the existing instance of Velocity instead of requiring a new one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this, velocity-react was always requiring a new instance of velocity-animate, so require('velocity-animate/velocity-ui') was attaching to the wrong instance. This finds an existing instance the correct way (the same way velocity.ui.js does it)