Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update code in README.md and generate_content documentation #149

Merged
merged 2 commits into from
Jan 10, 2024
Merged

docs: Update code in README.md and generate_content documentation #149

merged 2 commits into from
Jan 10, 2024

Conversation

Hamza-nabil
Copy link
Contributor

@Hamza-nabil Hamza-nabil commented Dec 21, 2023 •
edited
Loading

Description of the change

  • Correct code examples in GenerativeMode.generate_content documentation

  • Adding Python language specification for code snippets in README.md for clarity.

Motivation

Type of change

Choose one: Documentation

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@Hamza-nabil Hamza-nabil requested a review from a team as a code owner December 21, 2023 18:40
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Dec 21, 2023
@Hamza-nabil Hamza-nabil changed the title docs: Update README.md AND docs: Update README.md and GenerativeMode.generate_content documentation Dec 21, 2023
@Hamza-nabil Hamza-nabil changed the title docs: Update README.md and GenerativeMode.generate_content documentation docs: Update code in README.md and generate_content documentation Dec 21, 2023
markmcd
markmcd approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@markmcd markmcd merged commit 4df472e into google-gemini:main Jan 10, 2024
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hamza-nabil @markmcd