Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Crash if label of PaymentItem is not provided #265

Open
omartinma opened this issue May 21, 2024 · 1 comment
Open

[iOS] Crash if label of PaymentItem is not provided #265

omartinma opened this issue May 21, 2024 · 1 comment

Comments

@omartinma
Copy link

Hi,

According to the model definition of PaymentItem the property label is not required. If we dont pass a value it will crash in iOS as soon as you call showPaymentSelector. I did not test it on Android yet, not sure if the same case there but I believe we have 2 options:

  1. Make the field not nullable.
  2. Add documentation about the need to pass a value on iOS

Thanks!

@JlUgia
Copy link
Member

JlUgia commented Jul 30, 2024

Hi @omartinma, thank you for reporting the issue.
I'm leaning towards making it required. Only documenting it will still yield crashes for some.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants