Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzing helper library and more fuzz targets #165

Merged
merged 8 commits into from
Oct 5, 2020

Conversation

mingxguo27
Copy link
Contributor

Created a fuzzing helper library / API to increase code reusability.

Added fuzz targets for specific input types. For example, we can treat inputs as ctap2 command parameters encoded in cbor or ctap1 raw messages. This increases the achieved coverage (from 400 to 1400 in ctap2 case) compared to treating inputs as raw messages.

@google-cla google-cla bot added the cla: yes label Sep 25, 2020
fuzz/fuzz_helper/src/lib.rs Outdated Show resolved Hide resolved
fuzz/fuzz_helper/src/lib.rs Outdated Show resolved Hide resolved
fuzz/fuzz_helper/src/lib.rs Show resolved Hide resolved
fuzz/fuzz_helper/src/lib.rs Outdated Show resolved Hide resolved
fuzz/fuzz_helper/src/lib.rs Outdated Show resolved Hide resolved
fuzz/fuzz_helper/src/lib.rs Outdated Show resolved Hide resolved
kaczmarczyck
kaczmarczyck previously approved these changes Sep 29, 2020
fuzz/fuzz_helper/src/lib.rs Outdated Show resolved Hide resolved
fuzz/fuzz_helper/src/lib.rs Outdated Show resolved Hide resolved
fuzz/fuzz_helper/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@gendx gendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few nits on the code, otherwise it looks good :)

kaczmarczyck
kaczmarczyck previously approved these changes Oct 2, 2020
fuzz/fuzz_helper/src/lib.rs Show resolved Hide resolved
gendx
gendx previously approved these changes Oct 5, 2020
@mingxguo27 mingxguo27 dismissed stale reviews from gendx and kaczmarczyck via cc0c9ee October 5, 2020 10:17
@gendx gendx merged commit f328971 into google:master Oct 5, 2020
@mingxguo27 mingxguo27 deleted the mingxguo-fuzzing-mvp branch October 8, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants