-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzzing helper library and more fuzz targets #165
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gendx
reviewed
Sep 28, 2020
kaczmarczyck
previously approved these changes
Sep 29, 2020
gendx
reviewed
Oct 2, 2020
gendx
reviewed
Oct 2, 2020
gendx
reviewed
Oct 2, 2020
gendx
reviewed
Oct 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few nits on the code, otherwise it looks good :)
kaczmarczyck
previously approved these changes
Oct 2, 2020
gendx
previously approved these changes
Oct 5, 2020
gendx
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a fuzzing helper library / API to increase code reusability.
Added fuzz targets for specific input types. For example, we can treat inputs as ctap2 command parameters encoded in cbor or ctap1 raw messages. This increases the achieved coverage (from 400 to 1400 in ctap2 case) compared to treating inputs as raw messages.