Skip to content

Commit

Permalink
Vulkan: legacy_dithering disallow reactivate when breaking RP
Browse files Browse the repository at this point in the history
Hitting the assert in dEQP GLES2.functional.fragment_ops.random.0:
https://crsrc.org/c/third_party/angle/src/libANGLE/renderer/vulkan/ContextVk.cpp;drc=52fe3116ead9a5de51ddad17fcb14bf8ecb3a69d;l=2347

Bug: b/292259684
Change-Id: Ib40b90dde3b271c714b6181e4ba4d70f3e1b5e86
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/4706174
Reviewed-by: Charlie Lao <cclao@google.com>
Auto-Submit: Roman Lavrov <romanl@google.com>
Commit-Queue: Roman Lavrov <romanl@google.com>
  • Loading branch information
romanl-g authored and Angle LUCI CQ committed Jul 21, 2023
1 parent f586ec9 commit 938ee1e
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/libANGLE/renderer/vulkan/ContextVk.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5099,6 +5099,9 @@ void ContextVk::updateDither()
FramebufferVk *framebufferVk = vk::GetImpl(mState.getDrawFramebuffer());
if (framebufferVk->updateLegacyDither(this))
{
// Can't reactivate: same framebuffer but the render pass desc has changed.
mAllowRenderPassToReactivate = false;

onRenderPassFinished(RenderPassClosureReason::LegacyDithering);
}
}
Expand Down

0 comments on commit 938ee1e

Please sign in to comment.