Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generated wrapper for nested struct with static fn #1380

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

roife
Copy link

@roife roife commented Jul 16, 2024

This PR fixes an issue with the wrappers for static functions in nested structs.

See the added test case:

struct A {
    struct B {
        static void f() {}
    };
};

Currently, autocxx would generates erroneous code namespace::A_B::f() instead of namespace::A::B::f().

@roife roife force-pushed the nested_struct_with_static_fn branch from baba451 to c2171a8 Compare July 16, 2024 06:27
@roife roife changed the title Fix generated wrapper nested struct with static fn Fix generated wrapper for nested struct with static fn Jul 16, 2024
@adetaylor
Copy link
Collaborator

Thanks for this - I'm unclear why the github CI hasn't run the full suite of tests against it, and I don't want to merge it without that.

@adetaylor
Copy link
Collaborator

I raised another PR for the same code to get tests running - #1387 - there's a failure which needs looking into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants