Fix Android lint errors #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address all of the Android Lint errors that exist in the code. For things outside of the android/ subtree, add a lint.xml file. Test: ./gradlew build
nmittler
approved these changes
Dec 20, 2016
| @@ -998,7 +998,7 @@ protected int doFinalInternal(byte[] output, int outputOffset, int maximumLen) | |||
| try { | |||
| aeadBadTagConstructor = Class.forName("javax.crypto.AEADBadTagException") | |||
| .getConstructor(String.class); | |||
| } catch (ClassNotFoundException | NoSuchMethodException e2) { | |||
| } catch (Exception e2) { | |||
There was a problem hiding this comment.
This is a slight change in behavior ... just making sure this is what you want.
There was a problem hiding this comment.
This should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address all of the Android Lint errors that exist in the code. For
things outside of the android/ subtree, add a lint.xml file.
Test: ./gradlew build